Permalink
Commits on Jul 22, 2016
  1. @jajm @kylemhall

    Bug 14793: New cataloguing plugin unimarc_field_225a_bis

    It is similar to unimarc_field_210c_bis, but searches in
    biblioitems.collectiontitle instead of biblioitems.publishercode
    
    Signed-off-by: Laurence Rault <laurence.rault@biblibre.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    jajm committed with kylemhall Sep 8, 2015
  2. @kylemhall

    Bug 16945: PatronSelfRegistration: Add note about setting PatronSelfR…

    …egistrationDefaultCategory
    
    In OPAC, patron self registration works only when
    PatronSelfRegistrationDefaultCategory is set to a valid patron category.
    
    This patch adds a note for
    PatronSelfRegistration on Home > Administration > System preferences.
    
    To test:
    - Apply patch
    - In staff client, search system preferences for PatronSelfRegistration
    - Verify that note appears with PatronSelfRegistration
    
    (Amended to fix typo, see comment #3, 2016-07-21 mv)
    
    Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk>
    
    Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Marc committed with kylemhall Jul 20, 2016
  3. @joubu @kylemhall

    Bug 16906: Simply remove the sDom definition to use the default one

    Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    joubu committed with kylemhall Jul 20, 2016
  4. @oleonard @kylemhall

    Bug 16906 - Add DataTables pagination and filter to top of saved SQL …

    …reports table
    
    This patch adds a DataTables toolbar to the top of the saved SQL reports
    table so that pagination and filtering controls are at the top as well
    as the bottom.
    
    To test, apply the patch and go to Reports -> Saved reports. There
    should be controls at the top of the table of saved reports for setting
    number of results, pagination, and searching.
    
    Signed-off-by: Marc Véron <veron@veron.ch>
    
    Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    oleonard committed with kylemhall Jul 12, 2016
  5. @joubu @kylemhall

    Bug 16847: Add empty option to Salutation/title

    At the OPAC there is no way to empty this value.
    I think it should be allowed to empty it.
    
    Signed-off-by: Marc Véron <veron@veron.ch>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    joubu committed with kylemhall Jul 4, 2016
  6. @joubu @kylemhall

    Bug 16847: Remove C4::Members::GetTitles

    This subroutine just reads the content of a pref, split it, add an
    empty string and returns.
    It is not really useful and the code in the script (memberentry.pl) uses
    the only occurrence of CGI::popup_menu
    Let's remove it and build the dropdown list in the template.
    
    Test plan:
    1/ Empty BorrowersTitles, edit a patron and confirm that the "Salutation"
    does not appear
    2/ Fill BorrowersTitles with "Mr|Mrs|Miss|Ms", edit a patron and confirm
    that the "Salutation" dropdown list is correctly filled.
    The default option should be selected if you are editing a patron with a
    title defined.
    This should also be tested at the OPAC.
    
    Followed test pan, works as expected in Staff and OPAC
    Signed-off-by: Marc Véron <veron@veron.ch>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    joubu committed with kylemhall Jul 4, 2016
  7. @kylemhall

    Bug 11606 - DBRev 16.06.00.011

    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    kylemhall committed Jul 22, 2016
  8. @joubu @kylemhall

    Bug 15451: Better error handling

    1/ If a librarian edit (add_validate) a non-existing csv profile, we
    explicitely die
    2/ If you try to delete a non-existing csv profile, you will now get a
    nice alert box
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    joubu committed with kylemhall Jul 22, 2016
  9. @bgkriegel @kylemhall

    Bug 15451: (followup) fix filename extension for csv file

    This patch does the same as basket/downloadcart.pl
    to set '.csv' as filename extension for downloadshelf.pl
    
    To test:
    1) Define a CSV MARC profile
    2) On staff download a list, extension is '.NN'
    with 'NN' the CSV profile id.
    3) Apply the patch
    4) Download again, check extension is now '.csv'
    
    Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    bgkriegel committed with kylemhall Apr 28, 2016
  10. @joubu @kylemhall

    Bug 15451: Do not considered a Resultset as a Result

    The previous calls were wrong, but there is something bad with the DB
    structure: export_format.profile should be a unique key.
    This patch fixes the previous calls and add a FIXME not to forget to fix
    the DB structure.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
    Previous test where done with all patches applied,
    including this one, and all worked.
    No errors
    
    Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    joubu committed with kylemhall Jan 6, 2016
  11. @joubu @kylemhall

    Bug 15451: Koha::CsvProfiles - Remove the residue

    This patch erase all traces of C4::Csv since it's not used anymore.
    All occurrences have been replaced by previous patches to use
    Koha::CsvProfiles.
    
    Note that GetMarcFieldsForCsv was not used prior this patch set.
    
    Test plan:
      git grep 'C4::Csv'
    should not return any result.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
    No more traces of the file.
    This produces a koha-qa fail, due to the missing file.
    No other errors
    
    Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    joubu committed with kylemhall Dec 30, 2015
  12. @joubu @kylemhall

    Bug 15451: Koha::CsvProfiles - Remove GetCsvProfile

    This subroutine just returned a csv profile for a given id.
    It is replaced in this patch by a call to Koha::CsvProfiles->find.
    
    There is nothing to test here, these changes have been tested in
    previous patches.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    joubu committed with kylemhall Dec 30, 2015
  13. @joubu @kylemhall

    Bug 15451: Koha::CsvProfiles - Remove GetCsvProfileId

    This subroutine returned the export_format_id for a given profile name.
    This can be done easily with the Koha::CsvProfiles->search method.
    
    Test plan:
    Export records using the misc/export_records.pl script and the
    export tool.
    If you are exporting using the MARC format, the profile filled in the pref
    ExportWithCsvProfile will be used (or the one passed in parameter of
    misc/export_records.pl).
    If you are exporting using the CSV format, you can choose a profile in
    the dropdown list.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
    Exported using tool & cmd, marc & csv. Pref is used.
    No errors
    
    Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    joubu committed with kylemhall Dec 30, 2015
  14. @joubu @kylemhall

    Bug 15451: Koha::CsvProfiles - Remove GetCsvProfiles

    This subroutine did the same job as GetCsvProfilesLoop, so this patch
    applies the same changes as the previous patch.
    
    Test plan:
    1/ Claim some serials, sql profiles should be listed
    2/ Export records using the export tool. MARC profiles should be listed.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
    Listed sql & marc profiles
    No errors
    
    Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    joubu committed with kylemhall Dec 30, 2015
  15. @joubu @kylemhall

    Bug 15451: Koha::CsvProfiles - Remove GetCsvProfilesLoop

    This subroutine returned the csv profiles for a given type.
    This could be done easily with the new Koha::CsvProfiles->search method.
    
    Test plan:
    To do at the OPAC and staff interface!
    1/ Export a list using a CSV profile
    2/ Export your CART using a CSV profile
    Note that only MARC profiles should be available.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
    Tested on staff/opac & cart/list
    Small problem on filename extension fixed in followup.
    No errors
    
    Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    joubu committed with kylemhall Dec 31, 2015
  16. @joubu @kylemhall

    Bug 15451: Rewrite the csv profile tool script

    This page was inconsistent with the other admin and tool pages.
    The 2 tabs 'New profile' and 'Edit existing profile' were useless, the
    ergonomic needs to be revisited.
    This patch applies the same script/page structure as others: by default
    a table containing all csv profiles is displayed with 2 action links:
    edit and delete.
    
    Test plan:
    1/ Create 1+ CSV profiles, with different types (marc and sql)
    2/ Update some values using the Edit link
    3/ Delete a CSV profile
    
    Note: When deleting a CSV profile, it would be great to warn the user if it is
    used.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
    No problems on create, update and delete.
    No errors
    
    Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    joubu committed with kylemhall Dec 31, 2015
  17. @joubu @kylemhall

    Bug 15451: Add the 2 new modules Koha::CsvProfile[s]

    There are based on Koha::Objets. Tests provided.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
    Test pass, no errors.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    joubu committed with kylemhall Dec 31, 2015
  18. @kylemhall

    Bug 16715: Proposed followup to use Sereal for serialization

    This manages to eke out a bit more performance on my machine.
    
    Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl>
    
    Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Jesse Weaver committed with kylemhall Jun 8, 2016
  19. @kylemhall

    Bug 11606: (followup) minor typos

    Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
    Internal signoff.
    
    Signed-off-by: Alexis Rodegerdts <arodegerdts@wallawallawa.gov>
    
    Signed-off-by: Dwayne Nance <dnance@ebsco.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Jesse Weaver committed with kylemhall Jun 14, 2016
  20. @WNickC @kylemhall

    Bug 11606: Add Novelist client to staff

    To test:
    1 - Apply patches
    2 - Update database
    3 - View detail pages for some records and ensure no changes have been made
    4 - Enable NovelistSelectStaffEnabled (and enter or have info in the
            Profile and password)
    5 - Set NovelistSelectStaffView to 'above'
    6 - View detail pages for some records, verify that if novelist info is
    available it is displyaed and nothign is displayed if not
    7 - Repeat with all staff view options
    
    Sponsored by:
       Walla Walla Public Library (http://www.wallawallapubliclibrary.org/)
       Los Gatos Library (http://www.losgatosca.gov/42/Los-Gatos-Library)
    
    Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
    Internal signoff.
    
    Signed-off-by: Alexis Rodegerdts <arodegerdts@wallawallawa.gov>
    
    Signed-off-by: Dwayne Nance <dnance@ebsco.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    WNickC committed with kylemhall May 27, 2016
  21. @ranginui @kylemhall

    Bug 7143 : More new devs

    confirmed dates against emails and downloads.koha-community.org
    Two names added correctly.
    
    Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    ranginui committed with kylemhall Jul 4, 2016
  22. @ranginui @kylemhall

    Bug 7143 : Adding new developers

    Claire Gravely seemed to be a cut and paste error.
    June 3 better matches git log.
    Three other names in history are in about as well.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
    
    Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    ranginui committed with kylemhall Jun 20, 2016
  23. @mderooy @kylemhall

    Bug 7143: [QA Follow-up] Adjusting developer information

    For consistency we should not only add firstnames to the list of
    developers in about.tt and history.txt.
    
    Adding some surnames with the help of git log and Bugzilla. Also
    corrected a closing li tag.
    Note that I did not find one surname: Natasha of Catalyst Academy.
    Probably Chris could add that missing piece.
    
    NOTE: Natasha piece still needs clean up.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
    
    Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    mderooy committed with kylemhall Jun 13, 2016
  24. @joubu @kylemhall

    Bug 16934: Add test for ModOrder

    Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    joubu committed with kylemhall Jul 21, 2016
  25. @kylemhall

    Bug 16934 - Cannot add notes to canceled and deleted order line

    Some librarians would like to be able to add notes to deleted order
    lines to keep track of data such as what title the order line was for.
    For some reason ModOrder dies if a biblionumber is passed in, even
    though it does not use biblionumber and does not need it to exist in any
    fashion! This limitation should be removed.
    
    Test Plan:
    1) Create a basket with an orderline
    2) Cancel the order / delete the record
    3) Click the "Add internal note" link for that order line
    4) Fill in a note and click "Save"
    5) Note the error
    6) Apply this patch
    7) Repeat steps 3-4
    8) Note this time the note is saved!
    
    Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk>
    
    Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    kylemhall committed Jul 18, 2016
  26. @joubu @kylemhall

    Bug 16958: Fix XSS in opac-imageviewer.pl

    Test plan:
    Trigger
    /opac-imageviewer.pl?biblionumber=14&imagenumber=7"><sCrIpT>alert(42)<%2fsCrIpT>
    
    => Without this patch you will see the JS alert
    => With this patch applied you won't see it
    
    Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
    Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    joubu committed with kylemhall Jul 22, 2016
  27. @kylemhall

    Bug 16947: Can not modify patron messaging preferences

    To verify:
    - Set syspref 'EnhancedMessagingPreferences' to 'Allow'
    - In staff client, go to a patron's detail page
    - Edit Patron messaging preferences (using link below table)
    - Save
    Result: Form does not save, stays open
    JavaScript error in intranet-tmpl/prog/js/members.js line 107
    TypeError: document.form.password is undefined
    
    To test:
    - Apply patch
    - Repeat steps above
    - Verify that messaging preferences save as expected
    - Verify that other patron modifications work as before
    
    NOTE: remember to force reload of the javascripts.
    
    Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Marc committed with kylemhall Jul 21, 2016
  28. @srdjan-catalyst @kylemhall

    Bug 16716: Replaced wrong GROUP BY with DISTINCT

    Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    srdjan-catalyst committed with kylemhall Jun 13, 2016
  29. @kylemhall

    Bug 15974: Rancor: Correctly select existing authorized value

    Test plan:
      1) Open up a record in Rancor with an itemtype besides the first in
         the list ('BK' in the sample itemtypes).
      2) It will show "Book" instead of the correct itemtype.
      3) Apply patch, reload the page.
      4) The correct itemtype should now show.
    
    NOTE: The scope is only 942$c. This corrects that.
    
    Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Jesse Weaver committed with kylemhall Jul 20, 2016
  30. @kylemhall

    Bug 16941: Can not add new patron in staff client

    To reproduce:
    - Go to staff client Home > Patron
    - New patron
    - Choose a category and fill form, submit
    Result: Form reloads, patron data are not saved.
    
    To test:
    - Apply patch
    - Repeat steps above
    - Verify that patron data are saved and the new patron's
      detail page displays
    - Try to enter a duplicate patron (e.g. same surname, firstname
      and birthday as above)
    - Verify that a duplicate message appears
    
    Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
    Works as advertised
    
    Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Marc Véron committed with kylemhall Jul 14, 2016
Commits on Jul 15, 2016
  1. @joubu @kylemhall

    Bug 16913: Koha::Patrons - Remove GetBorrowersNamesAndLatestIssue

    This subroutine has been added by
      commit 5904681
      Date:   Wed Mar 19 10:11:12 2008 -0500
        CleanBorrowers fixing.
    but has never been used.
    It can be removed safely.
    
    Test plan:
      git grep GetBorrowersNamesAndLatestIssue
    should not return any results.
    
    Signed-off-by: Marc Véron <veron@veron.ch>
    Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    joubu committed with kylemhall Jul 12, 2016
  2. @joubu @kylemhall

    Bug 16909: Koha::Patrons - Remove checkuniquemember

    C4::Members::checkuniquemember was not really nicely written, was only
    used once and was not covered by tests.
    I think it does not make sense to keep such complexity and have this
    code in the subroutine/method.
    Looking at this patch it seems that what this subroutine did can be done
    easily in the pl script in few lines.
    
    Test plan:
    1/ Create 2 organisations with the same "surname": you should get a
    warning.
    2/ Create 2 patrons (non-organisation) with the same
    surname/firstname/date of birth, you should get a warning
    
    Signed-off-by: Marc Véron <veron@veron.ch>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    joubu committed with kylemhall Jul 11, 2016
  3. @joubu @kylemhall

    Bug 16889: Remove C4::Items::biblioitems_columns and use Koha::Biblio…

    …items->columns instead
    
    Test plan:
    Add new rule to the "Automatic item modifications by age" tools
    (tools/automatic_item_modification_by_age.pl) and make sure the columns
    of the biblioitems table are correctly displayed in the 'Conditions'
    dropdown list.
    
    Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    joubu committed with kylemhall Jul 9, 2016
  4. @joubu @kylemhall

    Bug 16889: Remove C4::Items::columns and use Koha::Items->columns ins…

    …tead
    
    Test plan:
    Add new rule to the "Automatic item modifications by age" tools
    (tools/automatic_item_modification_by_age.pl) and make sure the columns
    of the items table are correctly displayed.
    
    Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    joubu committed with kylemhall Jul 9, 2016
  5. @joubu @kylemhall

    Bug 16889: Remove C4::Members::columns and use Koha::Patrons->columns…

    … instead
    
    Test plan:
    Import some patrons (tools/import_borrowers.pl) and make sure it imports
    the patrons correctly.
    
    Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    joubu committed with kylemhall Jul 9, 2016