Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Aug 31, 2015
  1. Bug 11584: (QA followup) add missing newline at end of YAML file

    Tomas Cohen Arazi authored
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
  2. Bug 13697: (QA followup) fix typo in sysprefs.sql

    Tomas Cohen Arazi authored
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
  3. @fredericd

    Bug 11190: (QA followup) for tests on jenkins

    fredericd authored Tomas Cohen Arazi committed
    When moving from Moose to Moo we didn't address a minor syntax change
    Moo introduces. This patch fixes that.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Commits on Aug 28, 2015
  1. Bug 14337: Add 2 more tests to be complete

    Jonathan Druart authored Tomas Cohen Arazi committed
    Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
  2. Bug 14337: Fix conflict with bug 9809

    Jonathan Druart authored Tomas Cohen Arazi committed
    The reserves.constrainttype does not exist anymore, it has been removed
    by bug 9809.
    
    Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
  3. @kylemhall

    Bug 14337: AllowRenewalIfOtherItemsAvailable counts holdable not for …

    kylemhall authored Tomas Cohen Arazi committed
    …loan items when checking renewability
    
    AllowRenewalIfOtherItemsAvailable checks
    C4::Reserves::IsAvailableForItemLevelRequest to see if the item is
    holdable, which catches not for loan values less than 0 ( i.e. holdable,
    but not circ-able ). However, since this feature is about
    actually checking out items to patrons, we should not count *any* not
    for loan items when deciding if the available items will satisfy all
    current holds.
    
    Test Plan:
     1) Enable AllowRenewalIfOtherItemsAvailable
     2) Create a record with two items
     3) Check out one item to a patron
     4) Ensure the item is renewable
     5) Place a hold on the record
     6) The item should now be non-renewable
     7) Add a second item to the record, but with a not for loan value < 0
     8) Note the checkout is still renewable
     9) Apply this patch
    10) Note the checkout is now non-renewable
    
    Works ok.
    
    Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
  4. @kylemhall

    Bug 14337: Add Unit Tests

    kylemhall authored Tomas Cohen Arazi committed
    Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
  5. @Putti

    Bug 14703: Holidays description shows \r\n for every new line

    Putti authored Tomas Cohen Arazi committed
    Adds a new line for the holiday's description instead of the string
    \r\n.
    
    Test plan:
    1. In tools -> Calendar look at some holiday's description
       (Do a new holiday with description of multiple lines if
       there is not already)
    2. Notice that there is characters \r\n if someone has put
       a newline in the holiday's description
    3. Apply patch
    4. See that the new lines show there now nicely
    
    Sponsored-by: Vaara-kirjastot
    
    Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
    Amended slightly: no need to replace title.
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
  6. Bug 11584: DBRev 3.21.00.21

    Tomas Cohen Arazi authored
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
  7. @xarragon

    Bug 11584: Syspref WYSIWYG, dropdown added

    xarragon authored Tomas Cohen Arazi committed
    This patch adds the 'Htmlarea' type to the dropdown box
    introduced by bug 14268, commit 6e3bcc3.
    
    Sponsored-By: Halmstad County Library
    
    Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
  8. @minusdavid

    Bug 11584: Introduce UseWYSIWYGinSystemPreferences syspref

    minusdavid authored Tomas Cohen Arazi committed
    This patch adds a system preference "UseWYSIWYGinSystemPreferences" to the Staff Client tab.
    
    By default, it is off, which means that the TinyMCE WYSIWYG editor won't be shown for system
    preferences with a type of "htmlarea".
    
    However, when it's on, it will show the editor for "Local Use" preferences with a "htmlarea"
    type, and for other system preferences in the "Opac", "Circulation", and "Staff Client" tabs,
    which I have re-assigned. (Basically, I grepped for HTML and changed the type for all
    the system preferences I found except for "IntranetNav", "OpacCustomSearch", and "OPACSearchForTitleIn",
    as a WYSIWYG editor would potentially break the output for these system preferences or
    add no value to them...)
    
    _TEST PLAN_
    
    0) Run `perl installer/data/mysql/updatedatabase.pl` after setting your environmental variables
    1) Check the Opac tab to make sure that the WYSIWYG is nowhere to be seen
    2) Change the "UseWYSIWYGinSystemPreferences" preference in "Staff Client" to "Show"
    3) Refresh the Opac tab and notice that many system preferences now have a WYSIWYG editor
    
    4) Try typing some text into these fields
    5) Note that it gets marked as "modified"
    6) Save the preference, and refresh the page
    7) Note that the content has been saved
    8) Take a look at how it's rendered on the actual webpage!
    
    Signed-off-by: Martin Persson <xarragon@gmail.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
  9. @minusdavid

    Bug 11584: Add TinyMCE license to about.pl

    minusdavid authored Tomas Cohen Arazi committed
    This patch adds the TinyMCE license info to about.pl
    
    Signed-off-by: Martin Persson <xarragon@gmail.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
  10. @minusdavid

    Bug 11584: Add wysiwyg editor to system preferences dealing with HTML

    minusdavid authored Tomas Cohen Arazi committed
    This patch adds the ability to use a WYSIWYG editor for system preferences.
    
    The key files that I touch are:
    
    1) admin/systempreferences.pl
    2) koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt
    3) koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt
    
    I also add:
    
    4) koha-tmpl/intranet-tmpl/prog/en/includes/wysiwyg-systempreferences.inc
    
    and
    
    5) koha-tmpl/intranet-tmpl/lib/tiny_mce/plugins/advimage
    
    This plugin is part of the TinyMCE distribution. It used to be in Koha, but
    then someone removed it. It's useful for preferences like "opacheader" though.
    
    *If you're using anything except IE, this should work super well. If
    you're using IE, it'll probably only work for keyboard input and dragging
    text within the editor box but not from outside of it. IE has worse
    security, so you can probably paste using the context menu paste.
    
    *While I think a WYSIWYG editor can be useful, there might be times
    where the content is displayed differently than it is in the editor
    because of higher level CSS and Javascript.
    
    Signed-off-by: Martin Persson <xarragon@gmail.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
  11. Bug 13791: (QA followup) fix perlcritic warning

    Tomas Cohen Arazi authored
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
  12. @joubu

    Bug 11880: Select what has been selected before

    joubu authored Tomas Cohen Arazi committed
    The previous patch wants to select the barcode option when the user is
    on the item search for label, in all cases.
    So even if 'title' is selected, a search done, and there is no result,
    the barcode index is selected anyway.
    In this case, the title option should be kept.
    
    Test plan:
    Confirm that the barcode option is the default choice, but other values
    are kept if the search does not return any result.
    
    Followed test plan, behaves as expected. Tested with all choices.
    Signed-off-by: Marc Veron <veron@veron.ch>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
  13. @fcapovilla

    Bug 11880: Select the barcode index by default then searching for lab…

    fcapovilla authored Tomas Cohen Arazi committed
    …el items.
    
    Test case:
    * Go to "Tools -> Label creator -> Manage batches"
    * Click on the "New batch" button
    * Click on the "Add item(s)" button
    * A search window should open. The "Barcode" value should be selected in the the selectbox.
    
    Followed test case. Patch behaves as expected.
    Signed-off-by: Marc Veron <veron@veron.ch>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
  14. Bug 13697: DBRev 3.21.00.20

    Tomas Cohen Arazi authored
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
  15. Bug 13697: (QA followup) idiomatic fix add > charge

    Tomas Cohen Arazi authored
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
  16. @kylemhall

    Bug 13697: (QA followup) Add Unit Test

    kylemhall authored Tomas Cohen Arazi committed
  17. Bug 13697: Syspref to not add a fee when a patron changes to a catego…

    Christophe Croullebois authored Tomas Cohen Arazi committed
    …ry with enrolment fee
    
    By default this syspref is "Do" to keep the previous behaviour.
    
    Test plan :
    
    1/ create 2 categories (A & B). B with enrolment fee
    2/ create a patron in category A
    3/ change the patron category from A to B
    4/ check that the patron has an enrolment fee to pay
    
    Apply the patch
    
    1/ create a new patron in category A
    2/ change the patron category from A to B.
    3/ check that the patron has an enrolment fee to pay
    4/ change the system preference 'FeeOnChangePatronCategory' to 'Don't';
    5/ create a new patron in category A
    6/ change the patron category from A to B
    7/ check that the patron has no enrolment fee to pay
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
  18. @wsalesky

    Bug 13383: 100/110/111 changes to XSLT

    wsalesky authored Tomas Cohen Arazi committed
    Test plan:
    1) Apply this patch
    2) Ensure you are using the default XSLT setting for the staff and opac search results and record details
    3) Find or create a record with MARC tags 100,110,111
    4) Perform an opac search that would show the record in the search results.
    5) Click title to review record.
    6) Note the fields updates 100,110,111 to show subfields a,b,c,d,q and t.Multiple fields are separated by span class=separator |. Includes 100$j and handles multiple relator terms/codes.
    7) Repeat steps 4 - 6 for the staff interface
    
    Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
  19. Bug 14737: wrong permissions required for cn_browser.pl plugin

    Tomas Cohen Arazi authored
    The cn_browser.pl cataloguing plugin only searches for used callnumbers
    on the bibliographic database. There is no need for this plugin to
    require special permissions besides access to the catalog.
    
    To test:
    - Link the cb_browser.pl cataloguing plugin to 952$o in your favourite cataloguing framework
    - Login with a superlibrarian user
    - Try the plugin
    => SUCCESS: you can use it
    - Login with a user that has the full 'tools' permission
    - Try the plugin
    => SUCCSES: you can use it
    - Login with a user that doesn't have full 'tools' permission
      but has the normal catalogue and cataloguing permissions.
    - Try the plugin
    => FAIL: you are requested to login with a different user
    - Apply the patch
    - Retry
    => SUCCESS: you can use it
    - Sign off :-D
    
    Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
    Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
  20. @eythian

    Bug 13791: (PM followup) Dependency normalisation for master

    eythian authored Tomas Cohen Arazi committed
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Commits on Aug 27, 2015
  1. @Putti

    Bug 14579: 'You are not logged in' should link to log in page

    Putti authored Tomas Cohen Arazi committed
    To test:
    1) Go to any page on the staff client and make sure you are not logged in (ie an error page, cgi-bin/koha/errors/400.pl)
    2) Try click on 'You are not logged in |'
    3) Notice it is not really a link and doesn't take you anywhere
    4) Apply patch
    5) Refresh page
    6) Click on what now says 'Log in |'
    7) Confirm that you are redirected to the intranet log in page
    
    Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
  2. Bug 14634: Warns when placing hold on record with no items

    Aleisha authored Tomas Cohen Arazi committed
    To test:
    
    1) Create a new record in Cataloguing
    2) When done, instead of adding an item to the record, click on the Holds tab in the left nav
    3) Notice warns
    4) Apply patch and refresh page
    5) Click on Holds tab again
    6) Notice warns are gone and page still works
    
    Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
    Warns disappear; note that the display of the error message is still ugly.
    
    Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
  3. Bug 13791: (RM followup) Add new dependencies for packaging

    Tomas Cohen Arazi authored
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Commits on Aug 26, 2015
  1. @fredericd

    Bug 11190: sitemap.pl -- Generate a Catalog sitemap

    fredericd authored Tomas Cohen Arazi committed
    Add a script sitemap.pl to process all biblio records from a Koha
    instance and generate Sitemap files complying with this protocol as
    described on http://sitemaps.org. The goal of this script is to be able
    to provide to search engines direct access to biblio records. It avoid
    leaving search engine browsing Koha OPAC and so generating a lot of
    traffic, and workload, for a bad result.
    
    Thanks Magnus for testing, and helping to improve the script design.
    
    [2015.04.16] Switch from Moose to Moo.
    
    [2015.08.20] Add complete (more) UT.
    
    Signed-off-by: Magnus Enger <magnus@enger.priv.no>
    All options to the script work as expected and the output looks
    good. Nice enhancement!
    
    Signed-off-by: Frederic Demians <f.demians@tamil.fr>
    
    I signed-of my own patch after fixing various QA errors.
    
    Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
    Amended patch: replace tabs with spaces.
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
  2. @kylemhall

    Bug 14557: Add holds count to holds tab

    kylemhall authored Tomas Cohen Arazi committed
    Some librarians have expressed that it would be helpful if the holds tab
    displayed the count of holds for a record.
    
    Test Plan:
    1) Apply this patch
    2) Note the Holds tab for a record now displays the number of holds for that record
    
    Signed-off-by: Jason Robb <jrobb@sekls.org>
    
    Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
  3. @kylemhall

    Bug 14557: Clean up biblio-view-menu.inc

    kylemhall authored Tomas Cohen Arazi committed
    Signed-off-by: Jason Robb <jrobb@sekls.org>
    
    Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
  4. Bug 14714: Add tab-completion to koha-mysql command

    Tomas Cohen Arazi authored
    This patch introduces tab-completion in bash to the koha-mysql
    command. It completes using valid instance names. It stops completing
    once an instance name is chosen (i.e. it respects the fact that
    koha-mysql accepts only one instance name as parameter).
    
    To test:
    - Have a packages install (kohadevbox works)
    - Run:
      $ . debian/koha-common.bash-completion
    - Type
      koha-mysql <tab>
    => SUCCESS: You are prompted valid instance names for completion.
    - Sign off :-D
    
    Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
  5. Bug 14361: koha-restart-zebra fails and probably breaks upgrade

    Benjamin Rokseth authored Tomas Cohen Arazi committed
    This patch fixes the koha-restart-zebra and koha-stop-zebra scripts
    by adding pidfiles folder to the test is_zebra_running.
    It also adds pidfiles to the test is_indexer_running so that
    koha-rebuild-zebra will work properly.
    
    Test plan:
    1) check if zebrasrv is running, get pid of zebrasrv
       ps ax | grep zebrasrv
    2) In my case, there was also a warning on the about.pl page on a fresh
       install: Error message from Zebra: 1011 (bad credentials)
    3) try to restart zebra
       koha-restart-zebra instancename
       You will get a msg :
       Zebra does not appear to have been running for instancename
       Starting Zebra server for instancename
    4) check again if zebrasrv is running
        ps ax | grep zebrasrv
       and see that pid has not changed, thus it is not restarted
    5) Apply patch
    6) repeat 4) and watch now how pid has changed
       If there was a warning on about.pl it should now be gone
    
    Signed-off-by: Mason James <mtj@kohaaloha.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
    Good catch Benjamin! It works as expected with the patch.
  6. @kylemhall

    Bug 12632: (regression tests) Unit Tests

    kylemhall authored Tomas Cohen Arazi committed
    Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
  7. @kylemhall

    Bug 12632: Hold limits ignored for record level holds with item level…

    kylemhall authored Tomas Cohen Arazi committed
    … itemtypes
    
    The crux of the issue is that if you are using item level itemtypes, but
    are allowing biblio levels holds, those holds do not have items.
    
    So, in CanItemBeReserved, when Koha counts the number of holds to
    compare against the given rule, it will always give 0 ( except of course
    for found holds, and the occasional item-level hold ).
    
    So the query is saying "link each of these reserves to the reserved
    item, and count the number of reserves this patron where the itemtype is
    DVD". However, since these are all record level reserves, there are no
    items to link to, and so when it looks for all reserves this and item
    whose itemtype is DVD, it finds zero reserves!
    
    This patch solves the problem by looking first at the item level
    itemtype, and if it does not exist, then it looks at the record
    level itemtype. For installations using record level itemtypes, the
    behavior remains unchanged.
    
    Test plan:
    1) Enable item level itemtypes
    2) Create two records with one item each of a given itemtype
    3) Create a single issuing rule and limit the holds allowed for that
       itemtype to 1
    4) Place a record level hold on your first record
    5) Attempt to place a record level hold for the same patron on your
       second record. You should not be able to but you can!
    6) Apply this patch
    7) Repeat step 5, note you can no longer place the hold!
    
    Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
    
    Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
  8. Bug 7143: Add Benjamin Rokseth to the projects history file and about…

    Tomas Cohen Arazi authored
    … page
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
  9. Bug 7143: spaces in history.txt instead of tabs break display on website

    Liz Rea authored Tomas Cohen Arazi committed
    This may be the only place in koha where a tab should be a tab and not 4 spaces.
    
    I'll try to fix the script that does the conversion for the website to handle 4 spaces instead of tabs, but for now can we have this?
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Something went wrong with that request. Please try again.