Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
"Interval" update in /collectd/collectd.d/ will not affect the plugins already uploaded in collectd.conf #2444
When we want to update in /collectd/collectd.d/ the interval to a different value then the default, it will not affect the plugins that are loaded by default in the collectd.conf - cpu, memory, interface, disk, rrd plugins.
Interval should apply to all plugins when it is set in the first file in /collectd/collectd.d/
Interval will not affect the plugins that are loaded in the collectd.conf.
Steps to reproduce
I believe all plugins should not be loaded in the collectd.conf
if you do the following:
then the foo plugin will have an interval of 10 seconds and the bar plugin will have an interval of 20 seconds. That is because the callbacks are registered as the config is loaded and the foo plugin doesn't "see" the later 20 second interval setting.
My recommendation would be to set global options, such as
Hope this helps, best regards,
I'd personally prefer upstream's conf to only have comments, and only include some/dir.d/*.conf .
TL,DR: @didib suggests to comment out all
For more context: the reasoning, back in the day, was that a config with some commonly used plugins loaded would make it easier for users to get started. However, that was a time when collectd was much simpler and it was more common for users to build it from source. These days, I'd argue it's more important to us to cater to the needs of distributions – people building from source usually can handle themselves. Ultimately I see this as your call though.
From a Debian POV I honestly don't care about the default config because we ship our own config anyway. That said, I'd be happy to talk about unification across distributions -- I think that would make a lot of sense actually.
From an upstream POV, it's really hard to say what's the right default. Given the large number of potential use-cases, I don't think it's actually possible to still have a good default (that's a problem for distributions as well imho).
I agree it's a problem for distributions too, but a somewhat different one.
For upstream, assuming that these days the main direct users are either distributors or people that know what they are doing, I think it's ok to have everything commented out, perhaps except for a single 'include someplace.d'.
For distributions, I agree it makes sense to provide some non-empty useful default config, but IMO current issue does affect everyone - optional packages and/or users should be able to affect the configuration of loaded-by-default plugins without changing the conf, so these plugins should be loaded from some file inside the include dir, so that it's possible to add files before/after that file.
Re converging distributions: I think it makes sense to have the upstream default same as Debian's ('/etc/collectd/collectd.conf.d'), because I personally find it nicer, and the others (including us - CentOS-OpsTools/oVirt) will have to decide for themselves how to adapt - either ignore upstream until our next major version (where we can more easily break stuff), or create a symlink, include both places, etc.