Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogOnce option for df plugin #2910

Merged
merged 1 commit into from Mar 2, 2020
Merged

LogOnce option for df plugin #2910

merged 1 commit into from Mar 2, 2020

Conversation

themylogin
Copy link
Contributor

@themylogin themylogin commented Aug 27, 2018

ChangeLog: plugin df: Add LogOnce option

Enabling LogOnce true option in df plugin reduces syslog spam when stat
constantly fails for any of the mounted partitions.

@dago
Copy link
Contributor

dago commented Feb 29, 2020

@themylogin Would you mind rebasing the PR and resolving the conflicts?

@dago dago added the Waiting for response - 1st time Waiting for contributor to respond - 1st call label Feb 29, 2020
Enabling LogOnce true option in df plugin reduces syslog spam when stat
constantly fails for any of the mounted partitions.
@themylogin
Copy link
Contributor Author

@dago done

@dago dago removed the Waiting for response - 1st time Waiting for contributor to respond - 1st call label Mar 1, 2020
@dago dago requested a review from rpv-tomsk March 1, 2020 13:47
@dago dago added this to the 5.11.0 milestone Mar 1, 2020
@dago dago requested a review from kwiatrox March 2, 2020 16:19
@dago dago merged commit 6c2ad36 into collectd:master Mar 2, 2020
@sunkuranganath
Copy link
Member

Thanks @dago for fast response.

}
} /* for traverse */

return (1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return (1)

This is outdated code style.
Why you introduce it again?

@dago, Who will do cleanup?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpv-tomsk If in doubt, I will 😄 Same goes for the other comments from you.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will see how and when you do that.

@dago dago mentioned this pull request Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants