Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
RFC: Commit access for outside contributors #2958
as you may be aware, the
What do you think?
As for me, I used "Automerge" label when I have some small change to commit, but I want PR to pass CI checks. So, I make PR, give it "Automerge" label and bot cares about PR, not me.
Next time, if I see what CI has failed, I will resolve that issue, or take no more care if CI succeeds.
At practice, there was cases when PR has approved maintainer review, but was not merged by anybody.
Also, this mades impossible to require review from two (or more) maintainers, when one checks code style and other can check implementation details. Should we give it up?
Will this change make it impossible to merge PR by maintainers w/o Code Owner Review? This unclear for me a bit.
"Code Owner Review" implementation can make things faster to merge, which is attractive for committers.
Thanks for your feedback. To clarify, my goal is to allow contributors to maintain "their" plugin without being blocked by us maintainers. Maybe we can achieve this with Github's owner concept alone, i.e. without involving the bot.
For example, consider this config:
We could then add "individual-author" as an outside contributor. This user should then be able to approve (and merge) changes to
The other example,
I just don’t want to catch a situation when maintainer will not be able to merge commit w/o code owner.
My expectation would be for Github to block the commit until you are happy and change the status of your review to
I absolutely understand that concern – I had the same concern every time I gave commit access to someone. My experience has been, though, that if you trust people they will repay you by behaving responsibly. That said, if it doesn't work out and we come to the conclusion that revoking commit access from an outside contributors will reduce work for maintainers, we can (and should) do that.