types.db: fix ping_droprate range spec #3244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yousong
added a commit
to yousong/packages
that referenced
this pull request
Aug 8, 2019
Upstream project's behaviour of reporting this data source in range 0-1 is used by at least CentOS 7 collectd 5.8.1, very likely the same behaviour is also in widely use by other distributions. The change is important for providing consistent experience across collectd deployments on different environments Ref: collectd/collectd#3244 Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
yousong
added a commit
to yousong/packages
that referenced
this pull request
Aug 8, 2019
Upstream project's behaviour of reporting this data source in range 0-1 is used by at least CentOS 7 collectd 5.8.1, very likely the same behaviour is also in widely use by other distributions. The change is important for providing consistent experience across collectd deployments on different environments Ref: collectd/collectd#3244 Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
|
Not likely the ci check failure was caused by the change here. |
yousong
added a commit
to yousong/packages
that referenced
this pull request
Aug 9, 2019
Upstream project's behaviour of reporting this data source in range 0-1 is used by at least CentOS 7 collectd 5.8.1, very likely the same behaviour is also in widely use by other distributions. The change is important for providing consistent experience across collectd deployments on different environments Ref: collectd/collectd#3244 Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
yousong
added a commit
to openwrt/packages
that referenced
this pull request
Aug 9, 2019
Upstream project's behaviour of reporting this data source in range 0-1 is used by at least CentOS 7 collectd 5.8.1, very likely the same behaviour is also in widely use by other distributions. The change is important for providing consistent experience across collectd deployments on different environments Ref: collectd/collectd#3244 Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
yousong
added a commit
to openwrt/packages
that referenced
this pull request
Aug 10, 2019
Upstream project's behaviour of reporting this data source in range 0-1 is used by at least CentOS 7 collectd 5.8.1, very likely the same behaviour is also in widely use by other distributions. The change is important for providing consistent experience across collectd deployments on different environments Ref: collectd/collectd#3244 Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
yousong
force-pushed
the
droprate-range
branch
from
83dc55d
to
815e42a
Compare
It's always in range 0-1 since the initial support for the data source in commit 9cc8e54
yousong
force-pushed
the
droprate-range
branch
from
815e42a
to
ba0b44c
Compare
aparcar
pushed a commit
to aparcar/packages
that referenced
this pull request
Aug 27, 2019
Upstream project's behaviour of reporting this data source in range 0-1 is used by at least CentOS 7 collectd 5.8.1, very likely the same behaviour is also in widely use by other distributions. The change is important for providing consistent experience across collectd deployments on different environments Ref: collectd/collectd#3244 Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
|
Friendly ping while I am working on collectd again. |
yousong
added a commit
to openwrt/packages
that referenced
this pull request
Nov 14, 2019
Upstream project's behaviour of reporting this data source in range 0-1 is used by at least CentOS 7 collectd 5.8.1, very likely the same behaviour is also in widely use by other distributions. The change is important for providing consistent experience across collectd deployments on different environments Ref: collectd/collectd#3244 Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com> (cherry picked from commit 2f66fa5) Ref: openwrt/luci#3308
|
Ping @octo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: types.db: fix ping_droprate range spec
It's always in range 0-1 since the initial support for the data source
in commit 9cc8e54