New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl_json fails to create unique fallback when URL is too long #582

Closed
XANi opened this Issue Mar 11, 2014 · 4 comments

Comments

Projects
None yet
2 participants
@XANi
Contributor

XANi commented Mar 11, 2014

I believe it's the same issue as #286, when I try to get few different stats from very long url like

http://127.0.0.1:8090/v3/metrics/mbean org.apache.activemq:BrokerName=localhost,Type=Queue,Destination=com.puppetlabs.puppetdb.commands
http://127.0.0.1:8090/v3/metrics/mbean/com.puppetlabs.puppetdb.command:type=global,name=processing-time

I get

[warning] The read function "curl_json-puppetdb-http://127.0.0.1:8090/v3/metrics/mbean/com.p" is already registered. Check for duplicate "LoadPlugin" lines in your configuration!

@mfournier

This comment has been minimized.

Show comment
Hide comment
@mfournier

mfournier Mar 30, 2014

Contributor

Yes, it looks so. This was apparently fixed in 5.4.0. Are you using an older version ? Can you close this bugreport if it is the case ? Thanks !

Contributor

mfournier commented Mar 30, 2014

Yes, it looks so. This was apparently fixed in 5.4.0. Are you using an older version ? Can you close this bugreport if it is the case ? Thanks !

@XANi

This comment has been minimized.

Show comment
Hide comment
@XANi

XANi Mar 30, 2014

Contributor

I was testing on 5.4.1, sorry for not mentioning that.

It was fixed for curl_xml, not for curl_json
https://github.com/collectd/collectd/blob/master/src/curl_xml.c#L979
https://github.com/collectd/collectd/blob/master/src/curl_json.c#L726

Contributor

XANi commented Mar 30, 2014

I was testing on 5.4.1, sorry for not mentioning that.

It was fixed for curl_xml, not for curl_json
https://github.com/collectd/collectd/blob/master/src/curl_xml.c#L979
https://github.com/collectd/collectd/blob/master/src/curl_json.c#L726

mfournier added a commit to mfournier/collectd that referenced this issue Mar 31, 2014

curl_json: also allow long callback names.
This is basically the same as 2f39281, which got applied to the
curl_xml plugin a few months ago.

Fixes #582.
@mfournier

This comment has been minimized.

Show comment
Hide comment
@mfournier

mfournier Mar 31, 2014

Contributor

Ok, you're perfectly right !

Can you give the patch in #592 a try and let me know if it solves the problem for you ? Thanks !

Contributor

mfournier commented Mar 31, 2014

Ok, you're perfectly right !

Can you give the patch in #592 a try and let me know if it solves the problem for you ? Thanks !

@XANi

This comment has been minimized.

Show comment
Hide comment
@XANi

XANi Apr 2, 2014

Contributor

Yup, it's working.

Contributor

XANi commented Apr 2, 2014

Yup, it's working.

@XANi XANi closed this Apr 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment