New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl plugin doesn't reset values_num #663

Closed
mnlipp opened this Issue Jun 29, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@mnlipp

mnlipp commented Jun 29, 2014

Using curl plugin with GaugeAverage seemed to work, but showed strange values on the long run.

Looking at the tail plugin, I find that the purpose of GaugeAverage obviously is to calculate the average of all (new) matches found between to invocations. This works, because in utils_tail_match:96 (i.e. when submitting the value) values_num is reset to 0.

The curl plugin lacks such a reset. So it doesn't calculate the average value of all matches found on the page. Rather, it calculates (and submits) the average of all values found since startup.

octo added a commit that referenced this issue Sep 3, 2014

src/utils_match.[ch]: Implement match_value_reset().
This is called from the curl and memcachec plugins. Previously, gauge
average, minimum and maximum values were calculated since the start of
the daemon, rather than per-interval. This is not the documented
functionality.

Fixes: #663
@octo

This comment has been minimized.

Show comment
Hide comment
@octo

octo Sep 3, 2014

Member

Thanks for reporting this issue @mnlipp! I believe the above commit should fix this.

Best regards, —octo

Member

octo commented Sep 3, 2014

Thanks for reporting this issue @mnlipp! I believe the above commit should fix this.

Best regards, —octo

@octo octo closed this Sep 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment