New slurm read plugins (do not necessarily merge) - #1198
Closed
rezib wants to merge 5 commits into
Closed
Conversation
Author
|
I just fixed my commit for x86_32 and rebased it on top on current master branch. |
octo
added
Pending feedback
Pending contributor action
and removed
Pending feedback
labels
When slurmd is build with multiple slurmd per node support, the name of the subdirectory where the cgroups are created changes to include the hostname (cpuset/slurm_NODENAME instead of cpuset/slurm). This patch supports this by trying both and add an option to select a node name if the nodename is not the local hostname.
This is the default in Slurm starting with version >=16.05.
Contributor
|
Can probably close this since #3037 was merged. |
Member
|
Yes, thank you all involved here. I'm closing this, since #3037 was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slurm is a job scheduler and workload manager that is very popular among the HPC community.
This pull request proposes 2 new read plugins to get metrics out of Slurm:
slurmctldplugin which sends RPC toslurmctlddaemon to get the number of CPU and nodes allocated to jobs. It relies on thelibslurmlibrary. Please note this plugin requires theGlobals trueparameter since thelibslurmlibrary also load a 2nd row of plugins withdlopen(). This plugin is designed to run on Slurm job scheduler server of the supercomputer.slurmdplugin which browse Slurm job specifics (cpuset) cgroups to get the jiffies of the CPU allocated to jobs and do the sum of memory PSS of all PIDs of the job. This plugin requires theTaskPlugin=task/cgroupto be enable in Slurm configuration file. This plugin is desgined to run on all compute nodes of a supercomputer.My intent is not necessarily to merge these plugins in upstream collectd repository (unless you would be happy to do so), but I would be pleased to get code review from peers and people used to develop such collectd plugins :)
I've tried to follow the development guidelines and re-use existing functions as much as possible. As I am not an experienced C developer very familiar with portability considerations (only tested on Linux and amd64), I would be pleased to get feedback on this matter too!