ovs_stats: Implement OVS statistics plugin. #2137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OVS stats plugin uses OVS utils to get available bridge/interface statistics from OVSDB. Change-Id: Iabe71d64fef7fdbfd5a272c3599a92bce2adf055 Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
rubenk
reviewed
Feb 8, 2017
src/collectd.conf.pod
Outdated
| @@ -5524,6 +5524,54 @@ use B<Interval> option of the OVS B<LoadPlugin> block settings. For milliseconds | |||
| simple divide the time by 1000 for example if the desired interval is 50ms, set | |||
| interval to 0.05. | |||
|
|
|||
| =head2 Plugin C<ovs_stats> | |||
|
|
|||
| The I<ovs_stats> plugin collects a statistics of OVS connected interfaces. | |||
There was a problem hiding this comment.
statistics is plurar, so please remove the 'a'
rubenk
reviewed
Feb 8, 2017
src/ovs_stats.c
Outdated
| }; | ||
|
|
||
| /* Entry into the list of network bridges */ | ||
| static bridge_list_t *g_bridge_list_head = NULL; |
There was a problem hiding this comment.
no need to zero-initialize statics.
rubenk
reviewed
Feb 8, 2017
src/ovs_stats.c
Outdated
| }; | ||
|
|
||
| static const iface_counter ovs_stats_counter_name_to_type(const char *counter) { | ||
| iface_counter index = not_supportred; |
rubenk
reviewed
Feb 8, 2017
src/ovs_stats.c
Outdated
| static const char plugin_name[] = "ovs_stats"; | ||
|
|
||
| typedef enum iface_counter { | ||
| not_supportred = -1, |
rubenk
reviewed
Feb 8, 2017
src/ovs_stats.c
Outdated
| static int ovs_stats_is_monitored_bridge(const char *br_name) { | ||
| int rc = 0; | ||
| /* if no bridges are configured, return true */ | ||
| if (!(rc = (g_monitored_bridge_list_head == NULL))) |
There was a problem hiding this comment.
It's a bit hard to follow this code. I believe if you can get rid of rc which you are treating as a bool this can be simplified a bit.
rubenk
reviewed
Feb 8, 2017
src/ovs_stats.c
Outdated
|
|
||
| /* Delete all ports from port list */ | ||
| static void ovs_stats_free_port_list(port_list_t *head) { | ||
| port_list_t *i, *del; |
There was a problem hiding this comment.
can you move these into the for loop?
rubenk
reviewed
Feb 8, 2017
src/ovs_stats.c
Outdated
|
|
||
| /* Delete all bridges from bridge list */ | ||
| static void ovs_stats_free_bridge_list(bridge_list_t *head) { | ||
| bridge_list_t *i, *del; |
rubenk
reviewed
Feb 8, 2017
src/ovs_stats.c
Outdated
|
|
||
| /* Handle OVSDB lost connection callback */ | ||
| static void ovs_stats_conn_terminate() { | ||
|
|
rubenk
reviewed
Feb 8, 2017
| } | ||
|
|
||
| /* Handle OVSDB lost connection callback */ | ||
| static void ovs_stats_conn_terminate() { |
rubenk
reviewed
Feb 8, 2017
src/ovs_stats.c
Outdated
| plugin_name, ovs_stats_cfg.ovs_db_node, ovs_stats_cfg.ovs_db_serv, | ||
| ovs_stats_cfg.ovs_db_unix); | ||
| /* connect to OvS DB */ | ||
| if ((ovs_db = ovs_db_init (ovs_stats_cfg.ovs_db_node, |
There was a problem hiding this comment.
ovs_db is static. You're using the g_ prefix for all other statics, I believe you should do the same here.
|
@maryamtahhan ping? |
|
@rubenk sorry for long reply will update this PR today or tomorrow |
Fixed issue with missing counter Signed-off-by: Taras Chornyi <tarasx.chornyi@intel.com>
Signed-off-by: Taras Chornyi <tarasx.chornyi@intel.com>
|
Thank you @maryamtahhan and @taraschornyi. |
jaroug
pushed a commit
to jaroug/collectd
that referenced
this pull request
Mar 1, 2017
ovs_stats: Implement OVS statistics plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OVS stats plugin uses OVS utils to get available
bridge/interface statistics from OVSDB.
Change-Id: Iabe71d64fef7fdbfd5a272c3599a92bce2adf055
Signed-off-by: Mytnyk, VolodymyrX volodymyrx.mytnyk@intel.com