virt plugin: Add physical cpu reporting

[ffromani]

Add a metric to report physical cpu consumed by the hypervisor,
split per user/system time. This is provided by libvirt since version
0.9.11, and used by oVirt.

We also extend the newly-added 'ExtraStats' option to allow
users to toggle on/off the new metric. Default is off.

Signed-off-by: Francesco Romani fromani@redhat.com

[rubenk]

src/virt.c: In function 'parse_ex_stats_flags':
src/virt.c:491:22: error: passing argument 1 of 'strcasecmp' makes pointer from integer without a cast [-Werror]
       if (strcasecmp(exstats[i], ex_stats_table[j].name) == 0) {
                      ^
In file included from ./src/daemon/collectd.h:45:0,
                 from src/virt.c:22:
/usr/include/string.h:534:12: note: expected 'const char *' but argument is of type 'char'
 extern int strcasecmp (const char *__s1, const char *__s2)
            ^
src/virt.c: In function 'lv_config':
src/virt.c:702:42: error: passing argument 1 of 'parse_ex_stats_flags' from incompatible pointer type [-Werror]
       extra_stats = parse_ex_stats_flags(exstats, numexstats);
                                          ^
src/virt.c:487:21: note: expected 'const char *' but argument is of type 'char **'
 static unsigned int parse_ex_stats_flags(const char *exstats, int numexstats) {
                     ^
cc1: all warnings being treated as errors
Makefile:6081: recipe for target 'src/virt_la-virt.lo' failed
make[1]: *** [src/virt_la-virt.lo] Error 1

[rubenk]

this shadows the global extra_stats, which is an unsigned int.

[rubenk]

Thanks again!

[rjkmurray]

116 files changed and 29 removed

[rubenk]

@fromanirh so, what's next? ;)

[ffromani]

Hi @rubenk! Next in lines are just fixes, we believe we filled all the gaps we had, so from now on it's polishing. I'll be in touch!
Thanks for your help!