Fix return value or loglevel for several plugins #3182
Conversation
faxm0dem
force-pushed
the
f/config-return-codes
branch
5 times, most recently
from
bc37a00
to
742f1db
Compare
|
Can you please re-run clang-format? |
3b9c7b2 introduced stricter RC check. This commit provides user feedback when config callback is failing. Change-Id: Ia9c13048e95559b5be84477fc1602ff418a1df37
faxm0dem
force-pushed
the
f/config-return-codes
branch
from
3ea62de
to
a894a10
Compare
|
I reran the clang lint, everything ok now? I can squash everything |
|
As you can see, that is not ok and CI still failing. |
|
sorry about that - should be okay now |
rpv-tomsk
added
Automerge
|
Further reading: https://github.com/orgs/collectd/teams/trusted-contributors/discussions/1 I do not understand why Team prevents other people from project developing. |
Some plugins' RC was != 0 and started to fail due to stricter verification introduced by 3b9c7b2. This commit fixes those return values. For some plugins, fix verbosity of error message: non-zero rc should be error, not warning. Change-Id: I9a3f1f80e266858b6744fd9d9d99b352b8d94306 Change-Id: Ibf6ebc6cdc93c6e105d488e4a131dcb6e8eea19b Change-Id: I35bac15fa0a89b068575739ac1cff0115c9d3a40 s Change-Id: I992002c56763fbdea5347e5b6e176cc86f5a08ce
Change-Id: Iae7c3208024372485fd0901898cbe2e178610082
faxm0dem
force-pushed
the
f/config-return-codes
branch
from
9ba0498
to
4af2afc
Compare
faxm0dem
changed the title
|
Hmm, automerge doesn't work? |
|
oops ? :-))) unexpectedly, right? :-)))) |
|
Team prevents other people from project developing. Live with it and enjoy. |
|
So, automerge issues have nothing to do with this patch. I'll merge it now manually. Let's take the discussion from here. |
| @@ -56,7 +57,8 @@ static int sl_config(const char *key, const char *value) { | |||
| } else if (strcasecmp(key, "NotifyLevel") == 0) { | |||
| notif_severity = parse_notif_severity(value); | |||
| if (notif_severity < 0) | |||
There was a problem hiding this comment.
Missing brackets for if? "Return 1" is outside of if scope.
Change-Id: I0972f74f3fff05cf29fa9b0be383f0b0df1e6d03 Fixes: collectd#3200
Fix return code introduced by #3182
Some plugins' RC was != 0 and started to fail due to stricter verification introduced by 3b9c7b2.
This commit fixes those return values. For some plugins, fix verbosity of error message: non-zero rc
should be error, not warning.
Fixes #3180
What I chose to do:
ChangeLog: fix incorrect return codes or log level for several plugin config callbacks