Skip to content
This repository

check for iptc_init in both iptc and ip4tc #35

Closed
wants to merge 1 commit into from

2 participants

Andrew Elwell Florian Forster
Andrew Elwell

./configure --enable-iptables was failing on fedora as iptc_init
wasn't found. This patches configure.in to also look in ip4tc

Andrew Elwell Also check in ip4tc for iptc_init
./configure --enable-iptables was failing on fedora as iptc_init
wasn't found. This patches configure.in to also look in ip4tc
7d7aba5
Andrew Elwell

hat tip also due to clundquist (@ChrisLundquist) on IRC for pointers where to look

Andrew Elwell

it looks like debian have come across this bug and patched it differently http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=614439 (not as clean IMHO :-)

Florian Forster
Owner

Hi Andrew,

since this is a bug fix, it should go in the collectd-4.10 branch. Could you please rebase/cherry-pick your commit to there and change this pull request (if that's possible; otherwise just open a new one)? Thanks :)

Florian Forster
Owner

Committed as 3835b23

Thank you very much for the patch :)

Florian Forster octo closed this February 28, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Feb 26, 2012
Andrew Elwell Also check in ip4tc for iptc_init
./configure --enable-iptables was failing on fedora as iptc_init
wasn't found. This patches configure.in to also look in ip4tc
7d7aba5
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 2 additions and 1 deletion. Show diff stats Hide diff stats

  1. 3  configure.in
3  configure.in
@@ -1854,9 +1854,10 @@ then
1854 1854
 	AC_CHECK_TYPES([iptc_handle_t, ip6tc_handle_t], [], [])
1855 1855
 fi
1856 1856
 # Check for the iptc_init symbol in the library.
  1857
+# This could be in iptc or ip4tc
1857 1858
 if test "x$with_libiptc" = "xpkgconfig"
1858 1859
 then
1859  
-	AC_CHECK_LIB(iptc, iptc_init,
  1860
+	AC_SEARCH_LIBS(iptc_init, [iptc ip4tc],
1860 1861
 			[with_libiptc="pkgconfig"],
1861 1862
 			[with_libiptc="no"],
1862 1863
 			[$with_libiptc_libs])
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.