🚀 perf(add): Only call subroutine if pair is not in the set yet.

collection-abstraction · Sep 1, 2020 · 9f3a69f · 9f3a69f
1 parent 945d903
commit 9f3a69f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/src/EfficientlyInvertiblePairs.js b/src/EfficientlyInvertiblePairs.js
@@ -18,9 +18,12 @@ export default class EfficientlyInvertiblePairs extends BasePairs {
 	}
 
 	add([A, B]) {
-		if (!this.has([A, B])) ++this.size;
-		insert(this._map, A, B);
-		insert(this._imap, B, A);
+		if (!this.has([A, B])) {
+			insert(this._map, A, B);
+			insert(this._imap, B, A);
+			++this.size;
+		}
+
 		return this;
 	}
 

diff --git a/src/MemoryEfficientPairs.js b/src/MemoryEfficientPairs.js
@@ -18,8 +18,11 @@ export default class MemoryEfficientPairs extends BasePairs {
 	}
 
 	add([A, B]) {
-		if (!this.has([A, B])) ++this.size;
-		insert(this._map, A, B);
+		if (!this.has([A, B])) {
+			insert(this._map, A, B);
+			++this.size;
+		}
+
 		return this;
 	}