Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

For responses, targetRelease is saved as a severity or responsibleManager #4

Closed
StevenLooman opened this Issue Feb 5, 2013 · 4 comments

Comments

Projects
None yet
2 participants

See https://github.com/collective/Products.Poi/blob/master/Products/Poi/browser/response.py#L439

The variable 'option' is used, but the variable is set in a different for loop, at line 420. As a result, the 'id' for a change is set to 'responsibleManager' or 'severity', instead of 'targetRelease'.

Untested, but the fix might be to replace option with 'targetRelease' at line 439.

Owner

mauritsvanrees commented Feb 5, 2013

Oops, did I write that? That certainly looks wrong. I'll have look later.

Owner

mauritsvanrees commented Feb 5, 2013

Nothing really goes wrong because of this, there may just be two changes with the same id:

[{'before': '(UNASSIGNED)', 'after': 'admin', 'id': 'responsibleManager', 'name': u'Responsible manager'},
 {'before': '1.0', 'after': '2.0', 'id': 'responsibleManager', 'name': u'Target release'}]

It is still wrong of course. Fixed in 71844a2.
Thanks for reporting this. Well spotted!

Thats the exact thing we found in our system. Title is valid, fortunately. Thank you for the quick action.

Owner

mauritsvanrees commented Feb 7, 2013

I have released 2.2 with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment