New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Most metadata displayed are now clickable links #5

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@tdesvenain
Member

tdesvenain commented Feb 28, 2013

No description provided.

@tdesvenain

This comment has been minimized.

Member

tdesvenain commented Feb 28, 2013

Also : display full name of manager in vocab
use state class on main tracker view

@@ -4,9 +4,13 @@
from Products.PythonScripts.standard import url_quote
from ZTUtils import make_query
ACTIVE_STATES = ['open', 'in-progress', 'unconfirmed', 'resolved']

This comment has been minimized.

@mauritsvanrees

mauritsvanrees Mar 1, 2013

Member

Why is resolved in here? That is not a really active state. Sure, confirmed resolved is more inactive, but issues may easily linger in the resolved state without ever getting confirmed.

This comment has been minimized.

@tdesvenain

tdesvenain Mar 2, 2013

Member

'active states' are the states where someone have something to act, so we want to display them. (we just want to hide closed and rejected issues)

This comment has been minimized.

@mauritsvanrees

mauritsvanrees Mar 6, 2013

Member

For me, solved would fall in the same category as closed and rejected.

@mauritsvanrees

This comment has been minimized.

Member

mauritsvanrees commented Mar 1, 2013

Looks good, thanks.
But several tests fail with this. Can you have a look?

@tdesvenain

This comment has been minimized.

Member

tdesvenain commented Mar 2, 2013

Hi Maurits, i'm sorry i shouldn't have made a pull request. it's too soon.

On Fri, Mar 1, 2013 at 11:47 PM, Maurits van Rees
notifications@github.comwrote:

Looks good, thanks.
But several tests fail with this. Can you have a look?


Reply to this email directly or view it on GitHubhttps://github.com//pull/5#issuecomment-14315954
.

Thomas Desvenain

Téléphone : 09 51 37 35 18

@tdesvenain tdesvenain closed this Mar 5, 2013

@mauritsvanrees

This comment has been minimized.

Member

mauritsvanrees commented Mar 6, 2013

Did you accidentally merge this to trunk in 9cfca6a?

@tdesvenain

This comment has been minimized.

Member

tdesvenain commented Mar 6, 2013

Yes, you're right i merged this accidentally :( I'm sorry, this is a
mistake.

I think I'd better fix it now.

I'm ok to remove "resolved" from active states.

On Wed, Mar 6, 2013 at 11:56 AM, Maurits van Rees
notifications@github.comwrote:

Did you accidentally merge this to trunk in 9cfca6ahttps://github.com/collective/Products.Poi/commit/9cfca6a080a0864541e1606bc85575e8c65dae1f
?


Reply to this email directly or view it on GitHubhttps://github.com//pull/5#issuecomment-14493467
.

Thomas Desvenain

Téléphone : 09 51 37 35 18

@mauritsvanrees

This comment has been minimized.

Member

mauritsvanrees commented Mar 30, 2013

I have released version 2.2.1 with this change. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment