Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Port Products.PrintingMailHost to Python3 and Zope 4 #6

Merged
merged 5 commits into from Feb 28, 2019
Merged

Conversation

@pbauer
Copy link
Member

@pbauer pbauer commented Oct 3, 2018

No description provided.

@pbauer
Copy link
Member Author

@pbauer pbauer commented Oct 3, 2018

This needs to be checked if it still works with py2 and also with Zope 2.

@pbauer pbauer changed the title WIP: Support for Python3 and Zope 4 WIP: Port Products.PrintingMailHost to Python3 and Zope 4 Oct 3, 2018
@pbauer pbauer requested a review from frisi Oct 3, 2018
from AccessControl import ClassSecurityInfo
from Products.PrintingMailHost import LOG, FIXED_ADDRESS
from base64 import decodestring
from email.message import Message

This comment has been minimized.

@mauritsvanrees

mauritsvanrees Oct 3, 2018
Member

This email.Message import will fail on Python 2.4. That is what the except ImportError was for.
This is fine of course, but it deserves a note in the changelog, and the Python 2.4 and Plone 3.3 classifiers should be removed.

This comment has been minimized.

@pbauer

pbauer Oct 4, 2018
Author Member

👍

Copy link
Member

@frisi frisi left a comment

maurits already mentioned valid points about 2.4 compatibility.
i'd say we you can remove the DevelopmentMode variable in addition.
LGTM otherwhise, thanks!

Products/PrintingMailHost/__init__.py Outdated Show resolved Hide resolved
Products/PrintingMailHost/__init__.py Outdated Show resolved Hide resolved
@pbauer pbauer merged commit 5002c0a into master Feb 28, 2019
@pbauer pbauer deleted the python3 branch Feb 28, 2019
@djowett

This comment has been minimized.

Copy link

@djowett djowett commented on 35e2fcf Feb 28, 2019

Hi @pbauer!

plone.api isn't convinced it's obselete :-/

https://github.com/plone/plone.api/blob/548aafea844325a63399da08a2229795dd2e8c44/src/plone/api/portal.py#L51

but thanks for all the hard work!

This comment has been minimized.

Copy link
Member Author

@pbauer pbauer replied Mar 1, 2019

@djowett Darn. Would you mind re-adding them with a comment that blames plone.api so others do not remove them again?

This comment has been minimized.

Copy link
Member Author

@pbauer pbauer replied Mar 1, 2019

Done with #7

This comment has been minimized.

Copy link

@djowett djowett replied Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants