Use real image sizes #158

Closed
agnogueira opened this Issue Apr 11, 2013 · 2 comments

Comments

Projects
None yet
3 participants
Contributor

agnogueira commented Apr 11, 2013

When you select a image size to be used in a basic tile, cover do this:

  1. Look to the original size of the image
  2. Create a new version of the image based in the original size.

To me, the right thing to do is:

  1. Look to the SELECTED SIZE image (selected in tile config)
  2. Create a new version of the image based in the SELECTED SIZE.

This is very important when you use addons like image.cropping and you have different images for different sizes

@ghost ghost assigned hvelarde Apr 11, 2013

Contributor

agnogueira commented Apr 11, 2013

image

Owner

hvelarde commented Apr 11, 2013

in fact what we are doing is a little bit different; we have two approaches:

basic tile: we store the UUID of the object and we try to access its image field, if it has one, and we store the original image inside the persistent tile, then, at render time, we generate the scale selected on the configuration, according to the template.

image tile: we simply copy the image to the persistent tile and generate the scale the same way as stated above.

the idea was that we could be able of changing the image directly in the tile and replace it with another image even as the new one was not previously loaded into the site.

I think we need to store also the scales when populating the tile to solve this issue.

I'll talk to @jpgimenez to find out a solution.

@ghost ghost assigned jpgimenez Apr 11, 2013

jpgimenez added a commit that referenced this issue Apr 11, 2013

@hvelarde hvelarde closed this in 77522bb Apr 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment