Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

document implementation of tiles with image fields #188

Closed
hvelarde opened this Issue Apr 26, 2013 · 3 comments

Comments

Projects
None yet
2 participants
Owner

hvelarde commented Apr 26, 2013

we have a huge issue and we need to fix it now: changes made to implement #158 have result on a cascade of errors and hurries to fix those errors have resulted on more errors and coding that hide the errors.

The problem

first, let's think a little bit on the original problem: why we need to change the text of title or description fields on a tile? because they don't fit well in the area available; on an image fields the problem is different: we use features included in packages like plone.app.imagecropping to create a miniature that shows a detail of the original image, not only in the front page, but also in other places like listings and so on.

The use cases

I'll try to explain use cases that we imagine here to see if we understand them and we can find a better solution; I'll use the image tile because it's easier:

1. user drops an existing image into the image tile

in this case we must refer to the original image and scales; if the user change the image or their scales, the image and scales in the tile will reflect these changes; I think this is pretty intuitive and ease to explain.

2. user uploads an image into the image tile

in this case the image is stored as an annotation in the cover and we rely, for now, on standard Plone mechanisms to create the scales for now; in next iteration we can implement support for in place editing of the scales.

now let's image similar situations on a different tile, the basic one:

3. user drops an object with an image into the basic tile

if the object has an field named 'image' or a method named getImage, we are in the first use case and we must keep a relation with the original image; if the image is stored on a different field name, we simply ignore it, and we are in next use case, which is...

4. user uploads an image into the basic tile

this is the same as the second use case.

The solution?

we have to accomplish the above:

  • documenting
  • covering everything with tests
  • without messing on the tile's templates
  • without hiding unnecessarily exceptions

so please let's think a little bit about it and write down how are we going to implement it before changing anything on code.

feedback, please, @agnogueira @ericof @jpgimenez @Quimera

keep-calm

@ghost ghost assigned jpgimenez Apr 26, 2013

Owner

hvelarde commented Apr 26, 2013

I fixed the mess and tests are passing again on master.

go! go! go!

Owner

hvelarde commented May 3, 2013

fixed in 57198a6

@hvelarde hvelarde closed this May 3, 2013

Owner

hvelarde commented May 3, 2013

image tile continues to be a mess: not configurable and not standard implementation.

@hvelarde hvelarde reopened this May 3, 2013

@hvelarde hvelarde added this to the 1.0a9 milestone May 2, 2014

@hvelarde hvelarde modified the milestones: 1.0a9, 1.0b1 Aug 19, 2014

@hvelarde hvelarde modified the milestone: 1.0b1 Oct 5, 2015

@hvelarde hvelarde added the wontfix label May 3, 2016

@hvelarde hvelarde closed this May 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment