Add support for custom image content type in banner tile #241

Closed
aclark4life opened this Issue Aug 4, 2013 · 9 comments

Comments

Projects
None yet
3 participants
@aclark4life
Member

aclark4life commented Aug 4, 2013

Currently the banner tile supports only the default "Image" type in Plone. Suggest adding custom image content type support via configurable form e.g. "select custom image types" (which can be expect to provide either an image attribute or getImage method)

@ghost ghost assigned marcosfromero Aug 23, 2013

@hvelarde

This comment has been minimized.

Show comment Hide comment
@hvelarde

hvelarde Aug 23, 2013

Member

in fact, the tile should be able to read an image from any content type having an 'image' field/attribute or a 'getImage' method.

Member

hvelarde commented Aug 23, 2013

in fact, the tile should be able to read an image from any content type having an 'image' field/attribute or a 'getImage' method.

@marcosfromero

This comment has been minimized.

Show comment Hide comment
@marcosfromero

marcosfromero Aug 23, 2013

Contributor

There's a branch to address this issue.
Check it before doing anything.

Contributor

marcosfromero commented Aug 23, 2013

There's a branch to address this issue.
Check it before doing anything.

@hvelarde

This comment has been minimized.

Show comment Hide comment
@hvelarde

hvelarde Aug 23, 2013

Member

just revert the change and start from scratch...

Member

hvelarde commented Aug 23, 2013

just revert the change and start from scratch...

@aclark4life

This comment has been minimized.

Show comment Hide comment
@aclark4life

aclark4life Aug 23, 2013

Member

@marcosfromero You mean the branch I created? @hvelarde Revert what?

Member

aclark4life commented Aug 23, 2013

@marcosfromero You mean the branch I created? @hvelarde Revert what?

@marcosfromero

This comment has been minimized.

Show comment Hide comment
@marcosfromero

marcosfromero Aug 24, 2013

Contributor

@aclark4life Yes, the branch you created.

Contributor

marcosfromero commented Aug 24, 2013

@aclark4life Yes, the branch you created.

@hvelarde

This comment has been minimized.

Show comment Hide comment
@hvelarde

hvelarde Aug 26, 2013

Member

revert this a229c32

Member

hvelarde commented Aug 26, 2013

revert this a229c32

@aclark4life

This comment has been minimized.

Show comment Hide comment
@aclark4life

aclark4life Aug 26, 2013

Member

Done in 8772a75

Member

aclark4life commented Aug 26, 2013

Done in 8772a75

@marcosfromero

This comment has been minimized.

Show comment Hide comment
@marcosfromero

marcosfromero Aug 28, 2013

Contributor

Closing here: #268

Contributor

marcosfromero commented Aug 28, 2013

Closing here: #268

@hvelarde

This comment has been minimized.

Show comment Hide comment
@hvelarde

hvelarde Aug 28, 2013

Member

please wait until the merge is done :-)

Member

hvelarde commented Aug 28, 2013

please wait until the merge is done :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment