Add support for Python 3 #129
Conversation
@pbauer wouldn't it make sense to always start a Python 3 migration with setting up a Travis job that runs the Py3 jobs additionally and marked as allowed failure? This way you can work on Py3 step by step making sure you don't break py2. |
avoid ResourceWarning on open files in Python 3
@pbauer getting near ... Plone 5.2/py2/py3 tests are green but Plone 5.1 and robot tests are currently deactivated ... stay tuned and DO NOT MERGE RIGHT NOW |
missing things for merge and release:
the last one is weird because if you run your instance on 5.1 in a "real life browser" and navigate to the field view it works. Anybody has a hint how to fix this for the zope.testbrowser @jensens @davisagli ? @djay if ok, we'll fix your pull request here and I'll close your's ... |
This comment has been minimized.
This comment has been minimized.
Jenkins CI reporting about add-on compatibility. - test-addon-5.1 |
This comment has been minimized.
This comment has been minimized.
Jenkins CI reporting about add-on compatibility. - test-addon-5.2 |
This comment has been minimized.
This comment has been minimized.
Jenkins CI reporting about add-on compatibility. - test-addon-5.2-3.7 |
This comment has been minimized.
This comment has been minimized.
Jenkins CI reporting about add-on compatibility. - test-addon-5.2-3.6 |
I agree, this can be merged. The version then needs to be increased on feature level. Since it is a massive change-set I would be super-safe and release first a RC. So, this can be field-tested and taken with a grain of salt. |
Thanks @petschki for seeing this through to the end |
and .... RELEASED https://pypi.org/project/collective.easyform/2.1.0rc1/ |
Fixes #128
TODO: