Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3 #129

Merged
merged 20 commits into from Mar 19, 2019
Merged

Add support for Python 3 #129

merged 20 commits into from Mar 19, 2019

Conversation

@pbauer
Copy link
Member

@pbauer pbauer commented Oct 3, 2018

Fixes #128

TODO:

  • Fix all tests
  • Make sure it still works in py2
@pbauer pbauer changed the title Start porting to python 3 Add support for Python 3 Nov 11, 2018
@pbauer pbauer force-pushed the python3 branch from 8ec5a0c to 999b7c8 Nov 23, 2018
@tisto
Copy link
Member

@tisto tisto commented Nov 24, 2018

@pbauer wouldn't it make sense to always start a Python 3 migration with setting up a Travis job that runs the Py3 jobs additionally and marked as allowed failure? This way you can work on Py3 step by step making sure you don't break py2.

@iham iham force-pushed the python3 branch from 286f8a4 to 351a0b4 Feb 8, 2019
zopyx and others added 9 commits Mar 14, 2019
avoid ResourceWarning on open files in Python 3
@petschki
Copy link
Member

@petschki petschki commented Mar 18, 2019

@pbauer getting near ... Plone 5.2/py2/py3 tests are green but Plone 5.1 and robot tests are currently deactivated ... stay tuned and DO NOT MERGE RIGHT NOW 😉

petschki added 4 commits Mar 18, 2019
@petschki
Copy link
Member

@petschki petschki commented Mar 18, 2019

missing things for merge and release:

  • rewrite robottests for Plone 5.1+ selectors (I did already a few)
  • forceSSL redirect not working in 5.1 because testbrowser is not really logged out (still has cmf.ModifyPortalContent permission)
  • investigate failing doctests for 5.1 (mentioned here #139 ) because of ZPublisher.HTTPResponse.default_encoding = 'iso8859-15'

the last one is weird because if you run your instance on 5.1 in a "real life browser" and navigate to the field view it works. Anybody has a hint how to fix this for the zope.testbrowser @jensens @davisagli ?

@djay if ok, we'll fix your pull request here and I'll close your's ...

@petschki
Copy link
Member

@petschki petschki commented Mar 18, 2019

If someone wants to put some love in the todo_*.robot tests feel free ... I'd recommend to merge and release this PR and make testing enhancements in a new PR.

/cc @pbauer @jensens

@jenkins-plone-org

This comment has been minimized.

Copy link

@jenkins-plone-org jenkins-plone-org commented on 110793f Mar 18, 2019

Jenkins CI reporting about add-on compatibility. - test-addon-5.1
Your add-on is compatible!
See the full report here: https://jenkins.plone.org/job/test-addon-5.1/22/

This comment has been minimized.

Copy link

@jenkins-plone-org jenkins-plone-org replied Mar 18, 2019

Jenkins CI reporting about add-on compatibility. - test-addon-5.2
Your add-on is compatible!
See the full report here: https://jenkins.plone.org/job/test-addon-5.2/7/

This comment has been minimized.

Copy link

@jenkins-plone-org jenkins-plone-org replied Mar 18, 2019

Jenkins CI reporting about add-on compatibility. - test-addon-5.2-3.7
Your add-on is compatible!
See the full report here: https://jenkins.plone.org/job/test-addon-5.2-3.7/17/

This comment has been minimized.

Copy link

@jenkins-plone-org jenkins-plone-org replied Mar 18, 2019

Jenkins CI reporting about add-on compatibility. - test-addon-5.2-3.6
Your add-on is compatible!
See the full report here: https://jenkins.plone.org/job/test-addon-5.2-3.6/10/

@jensens
Copy link
Member

@jensens jensens commented Mar 19, 2019

I agree, this can be merged.

The version then needs to be increased on feature level.

Since it is a massive change-set I would be super-safe and release first a RC. So, this can be field-tested and taken with a grain of salt.

@jensens jensens merged commit 70efe69 into master Mar 19, 2019
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on python3 at 92.737%
Details
@jensens jensens deleted the python3 branch Mar 19, 2019
@pbauer
Copy link
Member Author

@pbauer pbauer commented Mar 19, 2019

Thanks @petschki for seeing this through to the end 😄

@jensens
Copy link
Member

@jensens jensens commented Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

6 participants