KML Openlayers View don't show all results of the underlying Collection #21

Closed
me-kell opened this Issue May 26, 2013 · 2 comments

Comments

Projects
None yet
2 participants

me-kell commented May 26, 2013

In collective/geo/kml/browser/kmldocument.py (line 420) the method KMLTopicDocument.features calls the collection's method queryCatalog without parameters. i.e. the method's defaults are used: queryCatalog(self, batch=True, b_start=0, b_size=30, sort_on=None). Therefore the result ist restricted/limited to the b_size=30 even if the underlying Collection has more results.

Please change the call to self.context.queryCatalog(batch=False) since a batch-result probably makes no sense in a KML-Document. This sets no limit in the results and implicitly uses the limit of the underlying Collection.

Alternatively you could pass the limit of the underlying Collection and let the use define the Limit: queryCatalog(self, batch=True, b_start=0, b_size=self.context.limit, sort_on=None).

Best regards,
me-kell

@ghost ghost assigned gborelli May 26, 2013

Contributor

gborelli commented May 26, 2013

I have choosen to pass batch=False in the 'queryCatalog' call.
See: collective/collective.geo.kml@ba0189d

Please, let me know if it works properly for you.

@gborelli gborelli closed this May 26, 2013

me-kell commented May 26, 2013

I agree with your decission.
Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment