Removal of "collective.nitf.controlpanel.INITFSettings.relatable_content_types" in upgradeStep missing #208
Comments
|
we can remove it if it's no longer used. |
idgserpro
added a commit
that referenced
this issue
Jul 1, 2017
A test is not possible since relatable_content_types was in INITFSettings in 1.x but removed in 2.x. We can't add to registry without error. Closes #208
hvelarde
pushed a commit
that referenced
this issue
Jul 3, 2017
* Remove relatable_content_types record 1.x -> 2.x. A test is not possible since relatable_content_types was in INITFSettings in 1.x but removed in 2.x. We can't add to registry without error. Closes #208 * Fix changelog [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The record was removed in 5a27baa, but no upgradeStep to remove this record was added. Do you think it's needed or just having
<records interface="collective.nitf.controlpanel.INITFSettings" remove="true" />in uninstall is enough?We're just concerned from an usability perspective, doign 1.x > 2.x and going to registry records in controlpanel and search for INITF's interface the value is still there.
The text was updated successfully, but these errors were encountered: