Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up orphaned revisions doesn't work on Plone 5.1.5 #19

Closed
fredvd opened this issue Oct 2, 2019 · 4 comments
Closed

Clean up orphaned revisions doesn't work on Plone 5.1.5 #19

fredvd opened this issue Oct 2, 2019 · 4 comments

Comments

@fredvd
Copy link
Member

fredvd commented Oct 2, 2019

When I installed collective.revisionmanager 0.8 in a Plone 5.1.5 site

  • calculate statistics,
  • and try to delete all revisions for already deleted content items
  • recalculate staticts

nothing happens. The statistics still show the same number of revisions belonging to deleted items.

Doing exactly the same in a Plone 4.3.18 website set all revisions belonging to deleted items to 0.

This is a Plone 5.1 site, I would expect problems with Plone 5.2 with a completely updated Zope 4 stack, but 5.1 and 4.3.18 still use the same Zope somewhat.

@mauritsvanrees
Copy link
Member

Confirmed. The test buildout of this package uses Plone 5.0, where it works. When I update this to 5.1, deleting orphans no longer works.
When I go to the control panel, and then the List histories tab, I see in lines where it has gone wrong: "All revisions have been purged". But the history is apparently still there:

Screenshot 2019-10-02 at 21 35 02

Restarting Zope does not help. Using the Recalculate statistics button does not help. The ZMI shows the same.

@mauritsvanrees
Copy link
Member

I see the problem. Plone 5.1 uses CMFEditions 3.x, and this automatically purges versions of content that is deleted.

So in Plone 5.1:

  • When you delete an item, the history gets purged. The only thing that remains, is a bit of metadata.
  • Deleting the orphans does nothing.
  • Well, when you have deleting a Document in Plone 5.0, then upgraded to 5.1, and then delete the orphans, then this will completely get purged, as wanted.

So what is missing, is removing the small remaining metadata.

I will prepare a PR.
(I took the liberty of merging two of my own PRs from yesterday, so Travis is passing again.)

@tschorr
Copy link
Collaborator

tschorr commented Oct 7, 2019

@fredvd collective.revisionmanager 0.9 is out, could you check and verify whether it fixes your issue?

@mauritsvanrees
Copy link
Member

I think this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants