Atom render body #18

Merged
merged 34 commits into from Jan 22, 2014

Conversation

Projects
None yet
4 participants
Member

jpgimenez commented Oct 16, 2013

Fixes #13
Fixes #16
Fixes #19

Coverage Status

Coverage remained the same when pulling 3e8598f on atom_render_body into 2cbc187 on master.

Coverage Status

Coverage remained the same when pulling ba697d5 on atom_render_body into 2cbc187 on master.

Coverage Status

Coverage remained the same when pulling 9394dcd on atom_render_body into 2cbc187 on master.

Coverage Status

Coverage remained the same when pulling 9c35edb on atom_render_body into 2cbc187 on master.

Coverage Status

Coverage remained the same when pulling 60dbf8a on atom_render_body into 2cbc187 on master.

Owner

hvelarde commented Nov 22, 2013

this is still not working; I just tested on an empty site, added a News Item, enabled the render body option and it was empty on the feed.

Coverage Status

Coverage remained the same when pulling b202605 on atom_render_body into 2cbc187 on master.

Coverage Status

Coverage remained the same when pulling ee0cd02 on atom_render_body into 2cbc187 on master.

Owner

hvelarde commented Nov 25, 2013

still not working: feeds are not valid.

see http://validator.w3.org/feed/

also, note that the content-core macro render a lot of needless stuff for logged in users.

Owner

hvelarde commented on 8ee3ed4 Jan 8, 2014

we need a test for this and verify that Plone 4.3 doesn't have the same bug

Plone 4.3 has the very same bug. I reported the bug and thought that collective.syndication is the module used in Plone 4.3 :-O
Where is the source package for this in Plone4.3, is it something different than collective.syndication?

Member

jpgimenez commented Jan 22, 2014

Fix #18, #19, #16, #15 & #13

@ghost ghost assigned hvelarde Jan 22, 2014

Owner

hvelarde commented Jan 22, 2014

@jpgimenez see the description: that's the right way to do it.

also, next time let's try to fix one issue at a time: that way you make reviewers life easier and development speeds up by not having to wait for the whole thing to be fixed.

hvelarde added a commit that referenced this pull request Jan 22, 2014

@hvelarde hvelarde merged commit d38fe26 into master Jan 22, 2014

1 check passed

default The Travis CI build passed
Details

@hvelarde hvelarde deleted the atom_render_body branch Jan 22, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment