Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable manual sorting of selected taxonomy items #74

Open
wants to merge 10 commits into
base: master
from

Conversation

@petschki
Copy link
Member

petschki commented Nov 5, 2019

fixes #71

@petschki petschki requested a review from agitator Nov 5, 2019
petschki added 2 commits Nov 5, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 5, 2019

Coverage Status

Coverage increased (+0.7%) to 46.03% when pulling c99781f on petschki/issue-71 into d5af7b1 on master.

Copy link
Member

agitator left a comment

looks much better to me

@petschki

This comment has been minimized.

Copy link
Member Author

petschki commented Nov 6, 2019

@malthe maybe you can take a look at this?

@malthe

This comment has been minimized.

Copy link
Member

malthe commented Nov 6, 2019

I'm not sure I understand the solution here. It seems like all the code just deleted.

Either a clear analysis of the change should be presented, or a test case that shows the issue and how it's fixed with this change. It's been a while since I touched this code so it's hard for me to understand the correctness of it.

@petschki

This comment has been minimized.

Copy link
Member Author

petschki commented Nov 25, 2019

@malthe yes you're right and I'm sorry for this code cut. The problem is, I cannot clearly reproduce the strange behavior of miss-ordered taxonomies. but it happens ... and with this simpler code it doesn't happen again. maybe it's because of python3 ... need to make some more investigations.

petschki added 3 commits Nov 25, 2019
@petschki petschki changed the title Ensure Order of taxonomy items Enable manual sorting of selected taxonomy items Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.