Skip to content

Commit

Permalink
use flake8 instead of pep8 and pyflakes
Browse files Browse the repository at this point in the history
  • Loading branch information
hvelarde committed Dec 19, 2012
1 parent 833fe96 commit 4727770
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 16 deletions.
18 changes: 12 additions & 6 deletions Makefile
@@ -1,14 +1,21 @@
# convenience makefile to boostrap & run buildout
# use `make options=-v` to run buildout with extra options
# convenience Makefile to run tests and QA tools
# options: zc.buildout options
# src: source path
# minimum_coverage: minimun test coverage allowed
# pep8_ignores: ignore listed PEP 8 errors and warnings
# max_complexity: maximum McCabe complexity allowed
# css_ignores: skip file names matching find pattern (use ! -name PATTERN)
# js_ignores: skip file names matching find pattern (use ! -name PATTERN)

SHELL = /bin/sh

options = -N -q -t 3
src = src/collective/upload/
minimum_coverage = 69
pep8_ignores = E501
css_ignores = ! -name bootstrap\* ! -name jquery\*
js_ignores = ! -name bootstrap\* ! -name jquery\*
max_complexity = 12
css_ignores = ! -name jquery\*
js_ignores = ! -name jquery\*

ack-install:
sudo apt-get install ack-grep
Expand All @@ -26,8 +33,7 @@ jshint-install: nodejs-install

python-validation:
@echo Validating Python files
bin/pep8 --ignore=$(pep8_ignores) $(src)
bin/pyflakes $(src)
bin/flake8 --ignore=$(pep8_ignores) --max-complexity=$(max_complexity) $(src)

css-validation: ack-install csslint-install
@echo Validating CSS files
Expand Down
16 changes: 6 additions & 10 deletions quality-assurance.cfg
@@ -1,18 +1,14 @@
[buildout]
parts +=
createzopecoverage
pep8
pyflakes
flake8

[createzopecoverage]
recipe = createzopecoverage

[pep8]
[flake8]
recipe = zc.recipe.egg
eggs = pep8

[pyflakes]
recipe = zc.recipe.egg
scripts = pyflakes
eggs = pyflakes
entry-points = pyflakes=pyflakes.scripts.pyflakes:main
eggs =
flake8
${buildout:eggs}
entry-points = flake8=flake8.run:main

0 comments on commit 4727770

Please sign in to comment.