Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Is the implementation for adding a new element in the "Add new" a good implementation? #9

Open
frapell opened this Issue · 1 comment

2 participants

@frapell
Collaborator

The implementation done in af4150f and 1ccac46 is a good implementation in the sense that it solves the problem, but it raises some issues:

  • If you want to do the same in some other package, you'll have to inherit from FactoriesMenu defined in this package, in order to not loose the menu item added here.
  • You need to add extra logic in getMenuItems in order to add this entry based on some condition (right now, it will be shown in every folderish item with the "Add new" menu)

In my opinion, we should revert this to the previous implementation, with a "dummy" content type, that it will be picked up by Plone's getMenuItems.

However, the best solution(in my opinion) would be if Plone's getMenuItems implemented some kind of adapter lookup that will allow any package to extend the functionality of this menu.

Thoughts ?

@frapell frapell referenced this issue in plone/plone.app.contentmenu
Open

Adding a way to include extra items to the "Add new" menu? #2

@ericof ericof was assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.