Rename global javascript function: formwidget_autocomplete_new_value

[kcleong]

For the contenttree browser (plone.formwidget.contenttree) the javascript global function 'formwidget_autocomplete_new_value' is used to update the field after an item has been selected in the contenttree overlay. I'm having problems updating a field with an existing value (see: plone/plone.formwidget.contenttree#16).

This global function is registered by two modules in my Plone 4.3.3 buildout. The last results by ack-grep is in contenttree widget, the function is called from there for contenttree.

# ack --follow formwidget_autocomplete_new_value
collective/z3cform/widgets/static/related.js
3:function formwidget_autocomplete_new_value(input_box,value,label) {
64:                        formwidget_autocomplete_new_value(input_box,$(this).attr('href'),$.trim($(this).text()));

plone/formwidget/autocomplete/jquery-autocomplete/formwidget-autocomplete.js
4:        formwidget_autocomplete_new_value(input_box,data[0],data[1]);
8:function formwidget_autocomplete_new_value(input_box,value,label) {

plone/formwidget/contenttree/jquery-contenttree/contenttree.js
21:                formwidget_autocomplete_new_value(input_box,$(this).attr('href'),$.trim($(this).text()));

The function in collective/z3cform/widgets/static/related.js is conflicting with the one in collective.z3cform.widgets. Where is this function used from c.z3cform.widgets? Maybe it is an idea to rename the function, to prevent conflicts.

[kcleong]

The function in autocomplete is unchecking the selected field and the one in c.z3cform.widgets is checking an selected field. Both functions aren't the same.

function in autocomplete: https://github.com/plone/plone.formwidget.autocomplete/blob/master/plone/formwidget/autocomplete/jquery-autocomplete/formwidget-autocomplete.js

function in c.z3cform.widgets: https://github.com/collective/collective.z3cform.widgets/blob/master/src/collective/z3cform/widgets/static/related.js

[hvelarde]

I think this was fixed already: https://github.com/collective/collective.z3cform.widgets/blob/master/CHANGES.rst#10b10-2014-10-08

please use the release I just made: https://pypi.python.org/pypi/collective.z3cform.widgets/1.0b10

[puittenbroek]

Problem still exists due to both having the function AND the this product install it's js after that of autocomplete. Changing the order to have the 'related.js' before 'formwidget-autocmplete.js' fixes the problem. But it's unclear to me why the duplicity exsists at all?

[hvelarde]

@puittenbroek we're no longer using this package; sorry, but I can't help further.

[puittenbroek]

Well the only problem I still have is due to collective.polls using this package.
collective/collective.polls#107

[hvelarde]

we can help on that :-)

[puittenbroek]

Was hoping on that ;) I'll close this issue one in favor of that issue.