Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pagetemplate import for Plone 4.3 compatibility #5

Merged
merged 1 commit into from Feb 13, 2013
Merged

Conversation

@jone
Copy link
Member

jone commented Feb 5, 2013

zope.app.pagetemplate.viewpagetemplatefile.ViewPageTemplateFile was moved to zope.browserpage.viewpagetemplatefile.ViewPageTemplateFile

  • zope.app.pagetemplate is no longer included in Plone >= 4.3
  • zope.browserpage.viewpagetemplatefile works from Plone >= 4.1

btw. is Products.Five.browser.pagetemplatefile.ViewPageTemplateFile preferred?

@garbas

This comment has been minimized.

Copy link
Contributor

garbas commented Feb 7, 2013

@davisagli i think is dropping 4.2 compatibility right? i guess bumping a version would then make sense , eg 2.0

@davisagli

This comment has been minimized.

Copy link
Member

davisagli commented Feb 9, 2013

I'd rather do a conditional import and avoid breaking compatibility.

@jone

This comment has been minimized.

Copy link
Member Author

jone commented Feb 12, 2013

@garbas @davisagli My initial change broke 4.1 and lower, not 4.2.
But anyway, I updated the PR with a conditional import, so that it is now backwards compatible.

@garbas

This comment has been minimized.

Copy link
Contributor

garbas commented Feb 13, 2013

@jone awesome!

garbas added a commit that referenced this pull request Feb 13, 2013
Fix pagetemplate import for Plone 4.3 compatibility
@garbas garbas merged commit ff88f68 into master Feb 13, 2013
@garbas garbas deleted the jone-plone-4.3 branch Feb 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.