Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Support login by email even when not using UUID userids fixes #26 #27
It took me a dozen hours to prove this one-line fix :-(.
Summary: when using email logins without UUID, as is required when working with LDAP, dexterity.membrane breaks. Users are not enumerated, because the enumeration queries on
Current status: confused. But that has more to do with the current code than with your pull request.
Your change makes sense. The user id should be stable, preferably even not change at all ever. So linking it to a changeable email address is not good. So pick a user id once and stick to it.
I haven't looked at the git history yet to see if that makes things clearer.
Okay, change in current status: going home before it starts raining. :-)
Some extra info:
So, in summary: the confusion between
I don't think that's fixable. Even in the context of the dx.membrane schema, the actual
This PR is essentially a one-line fix, where
Hold the merge. After doing some more code auditing, I'm reaching the conclusion we should just return
As to changing settings, that requires a reindex of the profiles. I should add utility methods for that.
Perfect! Thanks a lot. I will merge manually, so I don't include the internal version bumps.
I will add a note in the readme that the user may need to reindex manually.
Also, some of the tests don't work on Python 2.6. I will add a note that we drop support for that officially. Unofficially it may still work: the non-test code should still be fine. But we are only running Travis tests on Python 2.7.