Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing and creating field based on Permission #192

Merged
merged 1 commit into from Jun 30, 2019

Conversation

@iFlameing
Copy link
Contributor

commented Jun 24, 2019

Fixes #190
Just one problem with a nested folder structure we are not providing URL of the nested child which is present in the Folder thus we are not able to delete node for them. can you help me with this How I handle this situation :)

…hen made to publish
@iFlameing iFlameing requested a review from datakurre Jun 24, 2019
@coveralls

This comment has been minimized.

Copy link

commented Jun 24, 2019

Pull Request Test Coverage Report for Build 610

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.264%

Totals Coverage Status
Change from base Build 609: 0.0%
Covered Lines: 91
Relevant Lines: 99

💛 - Coveralls
@datakurre

This comment has been minimized.

Copy link
Collaborator

commented Jun 24, 2019

Could you rephrase? I didn’t fully understand the issue yet.

@datakurre

This comment has been minimized.

Copy link
Collaborator

commented Jun 24, 2019

Could you open an issue that we need to document ”live updates” for gatsby develop working best when ”all content types have publication workflow”.

You probably meant the case with default Plone where images and files don’t have workflow and their publication depends on their parents. Unfortunately that can be condigured for any types and there is no trivial solution to handle this.

@datakurre

This comment has been minimized.

Copy link
Collaborator

commented Jun 24, 2019

That said, somewhere there is a varoable of all known nodes that is saved as a state of the plugin that subsequent gatsby builds know to remove disappeared nodes. Maybe that could be used together with search.

Probably we should also learn to update the cache at some point.

I admit, I don’t currently remember the details of that ”state”, but might look into that later.

@iFlameing

This comment has been minimized.

Copy link
Contributor Author

commented Jun 28, 2019

@datakurre let us consider a Folder Structure as ( outerfolder -> innerFolder -> newsItem). All of them is public. When we change the outer folder to Private and left inner folder and newsItem public. we get a modified event with child and parent. We will able to delete node of outerFolder but we can't delete node for innerFolder and newsItem. How I can delete these nodes?

@datakurre

This comment has been minimized.

Copy link
Collaborator

commented Jun 28, 2019

I still don’t understand. I’m sorry. If the child remains public why it should be deleted.

Please, try to describe one more time :)

@iFlameing

This comment has been minimized.

Copy link
Contributor Author

commented Jun 29, 2019

@datakurre because we deleted the navigation and breadcrumbs node of outerfolder and we cannot navigate to the inner folder and newsitem. But you are right we don't need to delete the node of those inner folder and newsitem. I am thinking too much. You can merge this now :)

@datakurre datakurre merged commit b9eb4e3 into collective:master Jun 30, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 86.264%
Details
@iFlameing iFlameing deleted the iFlameing:permission branch Jun 30, 2019
@iFlameing iFlameing added the gsoc2019 label Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.