Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Updating Plone Collections #194

Merged
merged 2 commits into from Jul 2, 2019

Conversation

@iFlameing
Copy link
Contributor

commented Jun 28, 2019

Fixes #191
This is an initial commit regarding the issue. As you explained in the issue, we have to gather all nodes related to the collection and update them whenever some event is fired from the WebSocket. Please comment If I am missing something?

@iFlameing iFlameing requested a review from datakurre Jun 28, 2019
@coveralls

This comment has been minimized.

Copy link

commented Jun 28, 2019

Pull Request Test Coverage Report for Build 613

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.264%

Totals Coverage Status
Change from base Build 609: 0.0%
Covered Lines: 91
Relevant Lines: 99

💛 - Coveralls
Copy link
Collaborator

left a comment

I believe that this is missing resetting the timeout. Look for the documentation of setTimeout. It returns a value that can be used to cancel the timeout later. There should always be only one collection update timeout active at the same time.

@iFlameing

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2019

@datakurre can you review this again :)

@iFlameing iFlameing requested a review from datakurre Jul 2, 2019
@iFlameing iFlameing added the gsoc2019 label Jul 2, 2019
@datakurre datakurre merged commit ffaa169 into collective:master Jul 2, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 86.264%
Details
@datakurre datakurre added this to Done in GSOC 2019 via automation Jul 2, 2019
@iFlameing iFlameing deleted the iFlameing:setTimeOut branch Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
GSOC 2019
  
Done
3 participants
You can’t perform that action at this time.