IndexError fixes + bool(Component) to return True #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tnx for sorry for the delay! |
|
Thank you for your time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Found an IndexError in Component.from_ical() at https://github.com/collective/icalendar/blob/master/src/icalendar/cal.py#L350 so I replaced it with ValueError instead.
Also added bool() in Component so the instances of the class return True on bool() check (#141). Without it, the check at https://github.com/collective/icalendar/blob/master/src/icalendar/cal.py#L317 might always fail and raise Exception even for Components with ignore_exceptions == True.