Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated components to better conform to RFC 5545 #183

Merged
merged 1 commit into from May 26, 2016

Conversation

stlaz
Copy link
Collaborator

@stlaz stlaz commented Feb 11, 2016

#176

Should we ever get the strict mode described in #28, the properties description here needs to be correct. RFC5545 is not so easily readable so some of the properties might still be missing even in this patch. I should hope not, though.

@stlaz stlaz force-pushed the rfc5545 branch 2 times, most recently from 9f6d82e to 4f845ce Compare February 17, 2016 07:28
@stlaz stlaz mentioned this pull request Feb 17, 2016
@thet
Copy link
Member

thet commented May 26, 2016

Looks good to me!

@thet thet merged commit 640aa85 into collective:master May 26, 2016
@mauritsvanrees
Copy link
Member

Coredev 5.0 tests are broken after this: http://jenkins.plone.org/job/plone-5.0-python-2.7/4630/

There are two failures in plone.app.event, for example this one:

menu item "RRULE:FREQ=DAILY;COUNT=3;INTERVAL=1" missing or out of order

  File "/usr/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/home/jenkins/workspace/plone-5.0-python-2.7/src/plone.app.event/plone/app/event/tests/test_icalendar.py", line 84, in test_event_ical
    'END:VCALENDAR')
  File "/home/jenkins/workspace/plone-5.0-python-2.7/src/plone.app.event/plone/app/event/tests/test_icalendar.py", line 37, in checkOrder
    'menu item "%s" missing or out of order' % item
  File "/usr/lib/python2.7/unittest/case.py", line 424, in assertTrue
    raise self.failureException(msg)

Can you have a look?

@mauritsvanrees
Copy link
Member

BTW, coredev 5.1 is also broken, in the same tests.

@thet
Copy link
Member

thet commented May 26, 2016

Tnx for the pointer! that was just different ordering of the output, which we checked. Fixed in both 5.0 and 5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants