Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid browser cache (Return code 304 Not Modified) #37

Closed
wants to merge 1 commit into from

Conversation

rristow
Copy link
Contributor

@rristow rristow commented Feb 18, 2014

If the "plone.app.caching" is configured to cache the images, the image will not be updated in the browser (return code=304 not modified).

steps to reproduce:

  • go to @@caching-controlpanel/caching operations
  • set "File and image resources" caching to moderate or strong
  • go to @@croppingeditor and crop the image
  • After saving the "new" image will not be update in the browser (return code 304). The user can still force the update with CTRL+F5 Firefox)

@frisi
Copy link
Member

frisi commented Feb 18, 2014

thanks for pointing this out @rristow !

personally i'd call setModificationDate() after saving the crop since this is what actually modifies the image.

not sure if this leads to the same problem as we have in #21?
if the anwer is yes, then this change will delete all other cropped scales except the current one.

i think we should add a testcase that makes sure existing cropped scales are still cropped after cropping another scale.

@tomgross
Copy link
Member

It does lead to the same problem as in #21

@tomgross tomgross mentioned this pull request Mar 10, 2014
@tomgross
Copy link
Member

This is superseeded by pull request #38

@tomgross tomgross closed this May 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants