New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent value-converters from failing for non-intids. #13

Merged
merged 1 commit into from May 26, 2015

Conversation

Projects
None yet
3 participants
@deiferni
Member

deiferni commented May 20, 2015

The recently added value-converters for relations/relation-lists assume that int-ids are used when the plone.app.intid package is available.
This PR makes value-converters fault-tolerant when non-int-id values are provided.

Fixes #12.

@deiferni

This comment has been minimized.

Member

deiferni commented May 20, 2015

@thet i have implemented a possible fix for your problem. Please have a look and let me know if this works for you.

Note that this only makes the converter sections fault-tolerant for non int-ids. If you want to migrate from uuid to intid that would have to be handled separately.

jone added a commit that referenced this pull request May 26, 2015

Merge pull request #13 from collective/deif-fix-non-intids
Prevent value-converters from failing for non-intids.

@jone jone merged commit 529a4ac into master May 26, 2015

1 check passed

default CI Status: 1 SUCCESS
Details

@jone jone deleted the deif-fix-non-intids branch May 26, 2015

@thet

This comment has been minimized.

Member

thet commented May 26, 2015

@deiferni thanks for the fix! i couldn't verify yet, but i will do so later...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment