New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ordered move #134
Add ordered move #134
Conversation
| @@ -1,3 +1,4 @@ | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Philip,
Sorry about including changes to the readme by accident. I reverted them and they are no longer part of this pull request.
Best regards,
Sytse
This reverts commit b386048.
|
Thanks for this -- do all the tests pass for you? |
…case statements by using return. Better comments.
|
Hi Philip, I just got back from a holiday so that is why my answer took a while. Good that you ask about the tests, they worked before but running them today required a reload of an object (dosire@e236f06). I also took to oppotunity to refactor the code and tests a bit. The tests run now, this is my console output: Let me know if you have any questions. Best regards, |
|
@parndt Let me know if I can do anything to get this PR pulled. |
|
Merged into a5f7d9c thanks :-) |
|
@parndt Awesome! |
|
@parndt Would you mind doing a new release of the gem if you have time for that? |
|
@dosire sure thing.. just have to document the changes since 2.1.5 I probably won't get around to this in the next few hours so if you want to do this then it'd greatly help to get a quicker release :-) you'll also need to tell me whether we need a 2.1.6 or a 2.2.0 depending on the scope of changes. Thanks! |
|
@parndt I'm not in a hurry but of course I don't mind helping out. I very busy this week but I can do it Saturday, please let me know if that is an option. |
|
Thanks! I'll post back here if it happens sooner |
|
@parndt Awesome, I've scheduled it. |
|
@parndt My weekend contained a bit more GitLab.com and a bit less awesome_nested_set than planned, sorry. I'll have another try this Thursday. |
Thank you for the awesome gem. Please consider adding this functionality to add a child based on a certain ordering.