Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ordered move #134

Closed
wants to merge 8 commits into from
Closed

Conversation

dosire
Copy link
Contributor

@dosire dosire commented Apr 23, 2012

Thank you for the awesome gem. Please consider adding this functionality to add a child based on a certain ordering.

@@ -1,3 +1,4 @@

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Philip,

Sorry about including changes to the readme by accident. I reverted them and they are no longer part of this pull request.

Best regards,
Sytse

@parndt
Copy link
Collaborator

parndt commented Jun 24, 2012

Thanks for this -- do all the tests pass for you?

@dosire
Copy link
Contributor Author

dosire commented Jul 3, 2012

Hi Philip,

I just got back from a holiday so that is why my answer took a while. Good that you ask about the tests, they worked before but running them today required a reload of an object (dosire@e236f06).

I also took to oppotunity to refactor the code and tests a bit.

The tests run now, this is my console output:


sytse@hp5420s:~/Repos/awesome_nested_set$ git log -1 --oneline
2f698fd Test by name instead of id to generate easier to read errors. Reduce case statements by using return. Better comments.
sytse@hp5420s:~/Repos/awesome_nested_set$ rake
/home/sytse/.rbenv/versions/1.8.7-p352/bin/ruby -S rspec ./spec/awesome_nested_set_spec.rb ./spec/awesome_nested_set/helper_spec.rb
........................................................................................................................

Finished in 2.45 seconds
120 examples, 0 failures

Let me know if you have any questions.

Best regards,
Sytse

@dosire
Copy link
Contributor Author

dosire commented Jul 27, 2012

@parndt Let me know if I can do anything to get this PR pulled.

@parndt
Copy link
Collaborator

parndt commented Sep 12, 2012

Merged into a5f7d9c thanks :-)

@parndt parndt closed this Sep 12, 2012
@dosire
Copy link
Contributor Author

dosire commented Sep 12, 2012

@parndt Awesome!

@dosire
Copy link
Contributor Author

dosire commented Jan 27, 2013

@parndt Would you mind doing a new release of the gem if you have time for that?

@parndt
Copy link
Collaborator

parndt commented Jan 27, 2013

@dosire sure thing.. just have to document the changes since 2.1.5

I probably won't get around to this in the next few hours so if you want to do this then it'd greatly help to get a quicker release :-) you'll also need to tell me whether we need a 2.1.6 or a 2.2.0 depending on the scope of changes.

Thanks! 👍

@dosire
Copy link
Contributor Author

dosire commented Jan 27, 2013

@parndt I'm not in a hurry but of course I don't mind helping out. I very busy this week but I can do it Saturday, please let me know if that is an option.

@parndt
Copy link
Collaborator

parndt commented Jan 27, 2013

Thanks! I'll post back here if it happens sooner 👍

@dosire
Copy link
Contributor Author

dosire commented Jan 27, 2013

@parndt Awesome, I've scheduled it.

@dosire
Copy link
Contributor Author

dosire commented Feb 3, 2013

@parndt My weekend contained a bit more GitLab.com and a bit less awesome_nested_set than planned, sorry. I'll have another try this Thursday.

@dosire
Copy link
Contributor Author

dosire commented Feb 10, 2013

@parndt I've decided to release 2.1.6 since no new functionality was introduced, the PR is #174

@dosire dosire mentioned this pull request Feb 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants