Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Worker process exits if the job failure callback raises an exception. #276

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

robg commented Aug 4, 2011

This change traps exceptions raised while invoking the job failure callback to prevent the worker process from exiting. Since this callback is invoked prior to permanently failing the job, it seems reasonable to just swallow the exception and remove the job.

ajh commented Feb 10, 2012

I'd like to see this one merged in as well. The daemon should try to protect itself from exiting if a job misbehaves.

The clunky workaround is to rescue and ignore exceptions in failure callbacks for every job I implement.

It's better to rescue any exception (Exception) rather than StandardError and ancestors.

Owner

albus522 commented Sep 24, 2014

No longer an issue

@albus522 albus522 closed this Sep 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment