Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Make failed? method return a bool. #359

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

Does it make more sense if the failed? method returns a boolean? Do you care?

Owner

laserlemon commented Feb 24, 2012

While not totally necessary, expecting a boolean from a ? method is reasonable.

Merged manually in 4df5d96, updating some tests to use failed? and avoiding blank?.

Thank you!

@laserlemon laserlemon closed this Feb 24, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment