Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

more useful log message for delayed mailer #413

Closed
wants to merge 1 commit into from

2 participants

@codesnik

current 'Class#notice' isn't really helpful.
that commit changes display_name to something like 'FooMailer.notice'

@albus522
Owner

Please add tests

@codesnik

tests for those three lines?
okay.

@albus522
Owner

Adding tests for bug fixes or new features makes sure that we don't break things when changes are made in the future. It is not only to prove you did it right, but to prove that it still works in the future.

@albus522 albus522 closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 23, 2012
  1. @codesnik
This page is out of date. Refresh to see the latest.
Showing with 4 additions and 0 deletions.
  1. +4 −0 lib/delayed/performable_mailer.rb
View
4 lib/delayed/performable_mailer.rb
@@ -5,6 +5,10 @@ class PerformableMailer < PerformableMethod
def perform
object.send(method_name, *args).deliver
end
+
+ def display_name
+ "#{object}.#{method_name}"
+ end
end
module DelayMail
Something went wrong with that request. Please try again.