New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-wait and force-kill-waittime options to Delayed::Comand #459

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
10 participants
@pacoguzman

pacoguzman commented Dec 13, 2012

I've added support to these options that are used for Daemons gems.

In our case we have some long running jobs that we don't want to be locked when the process is killed on a new deployment, with these we avoid that problem and the process is going to still running after the current job is completed. Later our monitor system will start a new process.

What do you think? is this too specific to the daemons gem? I don't find another way to pass options to the daemons gem

@pacoguzman

This comment has been minimized.

Show comment
Hide comment
@pacoguzman

pacoguzman Dec 26, 2012

Some news with this

pacoguzman commented Dec 26, 2012

Some news with this

@asamix

This comment has been minimized.

Show comment
Hide comment
@asamix

asamix Dec 26, 2012

I want to use this. Because, delayed_job's process was frequently force-killed on restart them.

asamix commented Dec 26, 2012

I want to use this. Because, delayed_job's process was frequently force-killed on restart them.

@asamix

This comment has been minimized.

Show comment
Hide comment
@asamix

asamix commented Dec 26, 2012

@adamniedzielski

This comment has been minimized.

Show comment
Hide comment
@adamniedzielski

adamniedzielski May 19, 2015

Will you accept this pull request if I rewrite it to work with current master? I think that it's really useful especially when you suffer from "process with pid X won't stop, we forcefully kill it" as described in #593 /cc @albus522

adamniedzielski commented May 19, 2015

Will you accept this pull request if I rewrite it to work with current master? I think that it's really useful especially when you suffer from "process with pid X won't stop, we forcefully kill it" as described in #593 /cc @albus522

@tiredenzo

This comment has been minimized.

Show comment
Hide comment
@tiredenzo

tiredenzo Jun 30, 2015

Is it possible to resolve conflicts in this
I think that this feature should be integrated please.

tiredenzo commented Jun 30, 2015

Is it possible to resolve conflicts in this
I think that this feature should be integrated please.

@albus522

This comment has been minimized.

Show comment
Hide comment
@albus522

albus522 Jun 30, 2015

Member

Does this require a specific min version of the daemons gem?

Member

albus522 commented Jun 30, 2015

Does this require a specific min version of the daemons gem?

@apurvis

This comment has been minimized.

Show comment
Hide comment
@apurvis

apurvis commented May 16, 2016

👍

@rfroetscher

This comment has been minimized.

Show comment
Hide comment
@rfroetscher

rfroetscher May 16, 2016

have a more flexible solution that works with any version of the daemons gem here #916

rfroetscher commented May 16, 2016

have a more flexible solution that works with any version of the daemons gem here #916

@mike-stewart

This comment has been minimized.

Show comment
Hide comment
@mike-stewart

mike-stewart Jun 9, 2016

Any plans to update this PR now that #916 was merged? It looks like we would still need the force_kill_waittime option in Delayed::Comand, since it is not an accepted command line option in the daemons gem, so couldn't be passed through daemon-options.

mike-stewart commented Jun 9, 2016

Any plans to update this PR now that #916 was merged? It looks like we would still need the force_kill_waittime option in Delayed::Comand, since it is not an accepted command line option in the daemons gem, so couldn't be passed through daemon-options.

@lacco

This comment has been minimized.

Show comment
Hide comment
@lacco

lacco Jun 22, 2016

After some research in one of my projects, I agree with @mike-stewart : #916 doesn't solve the problem of passing the force_kill_waittime option, we need another change to support this.

lacco commented Jun 22, 2016

After some research in one of my projects, I agree with @mike-stewart : #916 doesn't solve the problem of passing the force_kill_waittime option, we need another change to support this.

@c960657

This comment has been minimized.

Show comment
Hide comment
@c960657

c960657 Apr 26, 2018

A new switch, --force_kill_waittime, has been added to Daemons in thuehlinger/daemons#65 (not yet released).

c960657 commented Apr 26, 2018

A new switch, --force_kill_waittime, has been added to Daemons in thuehlinger/daemons#65 (not yet released).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment