Add no-wait and force-kill-waittime options to Delayed::Comand #459

Open
wants to merge 1 commit into
from

Projects

None yet

9 participants

@pacoguzman

I've added support to these options that are used for Daemons gems.

In our case we have some long running jobs that we don't want to be locked when the process is killed on a new deployment, with these we avoid that problem and the process is going to still running after the current job is completed. Later our monitor system will start a new process.

What do you think? is this too specific to the daemons gem? I don't find another way to pass options to the daemons gem

@pacoguzman

Some news with this

@asamix
asamix commented Dec 26, 2012

I want to use this. Because, delayed_job's process was frequently force-killed on restart them.

@adamniedzielski

Will you accept this pull request if I rewrite it to work with current master? I think that it's really useful especially when you suffer from "process with pid X won't stop, we forcefully kill it" as described in #593 /cc @albus522

@tiredenzo

Is it possible to resolve conflicts in this
I think that this feature should be integrated please.

@albus522
Member

Does this require a specific min version of the daemons gem?

@apurvis
apurvis commented May 16, 2016

๐Ÿ‘

@rfroetscher

have a more flexible solution that works with any version of the daemons gem here #916

@eahanson-cfa eahanson-cfa referenced this pull request in codeforamerica/health Jun 2, 2016
Closed

stopping workers halts running jobs #509

@mike-stewart

Any plans to update this PR now that #916 was merged? It looks like we would still need the force_kill_waittime option in Delayed::Comand, since it is not an accepted command line option in the daemons gem, so couldn't be passed through daemon-options.

@lacco
lacco commented Jun 22, 2016

After some research in one of my projects, I agree with @mike-stewart : #916 doesn't solve the problem of passing the force_kill_waittime option, we need another change to support this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment