Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Support for not_queues #466

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants

arjes commented Jan 9, 2013

Hello,

I added support for a not_queues option to force the worker to skip over specific queues. I required this functionality so the workers would continue working on jobs with a blank queue, or anything else. Specifically I had jobs that HAD to be run on a sub-set of machines.

I looked for specs (for queue for example) to emulate, but was unable to find any.

--Brian

unknown added some commits Jan 9, 2013

Adding flags to accecpt not_queues option
The not queues option will force the worker to work all but the specified queues
Finishing support for not_queues
Added nessecary fields to worker class

This functionality would be really useful to me as well. How can we help to get it merged?

arjes commented Aug 24, 2013

I really wasn't very difficult to add. I may take a crack at merging my branch with the current development branch later but do not have much time right now.

@arjes Is your pull request complete? I see the option parsing changes but I don't see any changes to the actual queue selection. I suspect it would be more likely to be merged if everything was in a single commit and tests were included.

Owner

albus522 commented Aug 26, 2013

I would suggest wrapping all the functionality into --not-queue and not multiple possible arguments that do the same thing.

arjes commented Aug 26, 2013

@adamonduty The responsibility for job selection is in the adapter (https://github.com/arjes/delayed_job_active_record) I only updated the AR adapter since that is the only one I was using. And yes, your no doubt correct about the tests but at the time I did not know much about the tests in use, and I could not find tests for the QUEUE option to replicate.

@albus522 This was done since the core code uses QUEUE/QUEUES, and the NOT_QUEUES options takes the same parameters.

@albus522 albus522 closed this Sep 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment