New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow daemon-options to be passed through #916

Merged
merged 3 commits into from Jun 6, 2016

Conversation

Projects
None yet
5 participants
@rfroetscher

rfroetscher commented May 16, 2016

hey @albus522,

here I have a more flexible update of #459. the idea here is to allow users to pass options through to the daemons gem. i'm specifically interested in telling daemons not to forcefully kill my workers after their timeout.

your last question on that thread was whether the option they were adding in that PR was tied to a certain minimum version of the daemons gem. it is, but that minimum version of daemons (1.1.0) was released in 2010 https://rubygems.org/gems/daemons/versions/1.2.3.

this update also allows you to pass whatever options you want through so it shouldnt even matter what version of daemons you are using, so long as your daemon-options are geared towards the right version.

this works like this:

rob@rob-ubuntu ~/workspace/lumos_data_warehouse (test_of_delayed_job) => RAILS_ENV=development bundle exec script/delayed_job --queues=restart_test -n 1 --daemon-options='--no_wait' -p dj_worker start
delayed_job: process with pid 8879 started.
rob@rob-ubuntu ~/workspace/lumos_data_warehouse (test_of_delayed_job) => RAILS_ENV=development bundle exec script/delayed_job stop --daemon-options='--no_wait'
rob@rob-ubuntu ~/workspace/lumos_data_warehouse (test_of_delayed_job) => RAILS_ENV=development bundle exec script/delayed_job status
delayed_job: running [pid 8879]
rob@rob-ubuntu ~/workspace/lumos_data_warehouse (test_of_delayed_job) => RAILS_ENV=development bundle exec script/delayed_job status
delayed_job: running [pid 8879]
rob@rob-ubuntu ~/workspace/lumos_data_warehouse (test_of_delayed_job) => RAILS_ENV=development bundle exec script/delayed_job status
delayed_job: no instances running

please let me know if you have any questions or concerns.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 16, 2016

Coverage Status

Coverage decreased (-0.07%) to 91.127% when pulling 5bde69e on rfroetscher:no_wait into 1e67917 on collectiveidea:master.

coveralls commented May 16, 2016

Coverage Status

Coverage decreased (-0.07%) to 91.127% when pulling 5bde69e on rfroetscher:no_wait into 1e67917 on collectiveidea:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 16, 2016

Coverage Status

Coverage decreased (-0.07%) to 91.127% when pulling f212101 on rfroetscher:no_wait into 1e67917 on collectiveidea:master.

coveralls commented May 16, 2016

Coverage Status

Coverage decreased (-0.07%) to 91.127% when pulling f212101 on rfroetscher:no_wait into 1e67917 on collectiveidea:master.

@rfroetscher

This comment has been minimized.

Show comment
Hide comment
@rfroetscher

rfroetscher commented May 16, 2016

solves #593

@apurvis

This comment has been minimized.

Show comment
Hide comment
@apurvis

apurvis commented May 17, 2016

👍

@rfroetscher

This comment has been minimized.

Show comment
Hide comment
@rfroetscher

rfroetscher Jun 2, 2016

@albus522 anything i can do to make this acceptable?

rfroetscher commented Jun 2, 2016

@albus522 anything i can do to make this acceptable?

@rfroetscher

This comment has been minimized.

Show comment
Hide comment
@rfroetscher

rfroetscher Jun 3, 2016

@sferik any feedback on this?

rfroetscher commented Jun 3, 2016

@sferik any feedback on this?

@albus522 albus522 merged commit e3772d4 into collectiveidea:master Jun 6, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@rfroetscher

This comment has been minimized.

Show comment
Hide comment
@rfroetscher

rfroetscher Jun 6, 2016

Thanks for merging!

rfroetscher commented Jun 6, 2016

Thanks for merging!

@rfroetscher

This comment has been minimized.

Show comment
Hide comment
@rfroetscher

rfroetscher Nov 17, 2016

@albus522 Would you guys be able to make a release?

rfroetscher commented Nov 17, 2016

@albus522 Would you guys be able to make a release?

@sgrgic

This comment has been minimized.

Show comment
Hide comment
@sgrgic

sgrgic Apr 27, 2017

@albus522 when do you think this will be released? Thanks!

sgrgic commented Apr 27, 2017

@albus522 when do you think this will be released? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment