allow —-kill-waittime parameter to specify the kill timeout #925

Open
wants to merge 1 commit into
from

Projects

None yet

3 participants

@lacco
lacco commented Jun 23, 2016 edited

As already described in #459 , the default kill timeout of 20 seconds of the daemons gem might be not appropriate for every project, especially when having long running jobs. Currently, it is not possible to pass a different timeout, even #916 doesn't help here because the force_kill_waittime is a Ruby option.

Based on the work of @pacoguzman in #459 , I added an additional command parameter --kill-waittime=n.

@coveralls
coveralls commented Jun 23, 2016 edited

Coverage Status

Coverage increased (+0.3%) to 91.416% when pulling 8845f5b on lacco:force_kill_waittime into e3772d4 on collectiveidea:master.

@coveralls

Coverage Status

Coverage decreased (-0.1%) to 90.986% when pulling 8a7ac43 on lacco:force_kill_waittime into e3772d4 on collectiveidea:master.

@coveralls

Coverage Status

Coverage decreased (-0.1%) to 90.986% when pulling 8a7ac43 on lacco:force_kill_waittime into e3772d4 on collectiveidea:master.

@coveralls
coveralls commented Jun 24, 2016 edited

Coverage Status

Coverage increased (+0.3%) to 91.416% when pulling 8a7ac43 on lacco:force_kill_waittime into e3772d4 on collectiveidea:master.

@coveralls

Coverage Status

Coverage decreased (-0.1%) to 90.986% when pulling 13259ac on lacco:force_kill_waittime into e3772d4 on collectiveidea:master.

@coveralls

Coverage Status

Coverage decreased (-0.1%) to 90.986% when pulling 13259ac on lacco:force_kill_waittime into e3772d4 on collectiveidea:master.

@coveralls
coveralls commented Jun 24, 2016 edited

Coverage Status

Coverage increased (+0.3%) to 91.416% when pulling 13259ac on lacco:force_kill_waittime into e3772d4 on collectiveidea:master.

@mike-stewart

👍 Would be great to see this merged, I had to do something similar in my own fork to enable this option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment