New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow —-kill-waittime parameter to specify the kill timeout #925

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@lacco

lacco commented Jun 23, 2016

As already described in #459 , the default kill timeout of 20 seconds of the daemons gem might be not appropriate for every project, especially when having long running jobs. Currently, it is not possible to pass a different timeout, even #916 doesn't help here because the force_kill_waittime is a Ruby option.

Based on the work of @pacoguzman in #459 , I added an additional command parameter --kill-waittime=n.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 23, 2016

Coverage Status

Coverage increased (+0.3%) to 91.416% when pulling 8845f5b on lacco:force_kill_waittime into e3772d4 on collectiveidea:master.

coveralls commented Jun 23, 2016

Coverage Status

Coverage increased (+0.3%) to 91.416% when pulling 8845f5b on lacco:force_kill_waittime into e3772d4 on collectiveidea:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 24, 2016

Coverage Status

Coverage decreased (-0.1%) to 90.986% when pulling 8a7ac43 on lacco:force_kill_waittime into e3772d4 on collectiveidea:master.

coveralls commented Jun 24, 2016

Coverage Status

Coverage decreased (-0.1%) to 90.986% when pulling 8a7ac43 on lacco:force_kill_waittime into e3772d4 on collectiveidea:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 24, 2016

Coverage Status

Coverage decreased (-0.1%) to 90.986% when pulling 8a7ac43 on lacco:force_kill_waittime into e3772d4 on collectiveidea:master.

coveralls commented Jun 24, 2016

Coverage Status

Coverage decreased (-0.1%) to 90.986% when pulling 8a7ac43 on lacco:force_kill_waittime into e3772d4 on collectiveidea:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 24, 2016

Coverage Status

Coverage increased (+0.3%) to 91.416% when pulling 8a7ac43 on lacco:force_kill_waittime into e3772d4 on collectiveidea:master.

coveralls commented Jun 24, 2016

Coverage Status

Coverage increased (+0.3%) to 91.416% when pulling 8a7ac43 on lacco:force_kill_waittime into e3772d4 on collectiveidea:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 24, 2016

Coverage Status

Coverage decreased (-0.1%) to 90.986% when pulling 13259ac on lacco:force_kill_waittime into e3772d4 on collectiveidea:master.

coveralls commented Jun 24, 2016

Coverage Status

Coverage decreased (-0.1%) to 90.986% when pulling 13259ac on lacco:force_kill_waittime into e3772d4 on collectiveidea:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 24, 2016

Coverage Status

Coverage decreased (-0.1%) to 90.986% when pulling 13259ac on lacco:force_kill_waittime into e3772d4 on collectiveidea:master.

coveralls commented Jun 24, 2016

Coverage Status

Coverage decreased (-0.1%) to 90.986% when pulling 13259ac on lacco:force_kill_waittime into e3772d4 on collectiveidea:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 24, 2016

Coverage Status

Coverage increased (+0.3%) to 91.416% when pulling 13259ac on lacco:force_kill_waittime into e3772d4 on collectiveidea:master.

coveralls commented Jun 24, 2016

Coverage Status

Coverage increased (+0.3%) to 91.416% when pulling 13259ac on lacco:force_kill_waittime into e3772d4 on collectiveidea:master.

@mike-stewart

This comment has been minimized.

Show comment
Hide comment
@mike-stewart

mike-stewart Jun 27, 2016

👍 Would be great to see this merged, I had to do something similar in my own fork to enable this option.

mike-stewart commented Jun 27, 2016

👍 Would be great to see this merged, I had to do something similar in my own fork to enable this option.

@c960657

This comment has been minimized.

Show comment
Hide comment
@c960657

c960657 Apr 26, 2018

A new switch, --force_kill_waittime, has been added to Daemons in thuehlinger/daemons#65 (not yet released).

c960657 commented Apr 26, 2018

A new switch, --force_kill_waittime, has been added to Daemons in thuehlinger/daemons#65 (not yet released).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment