Fix the build #173
Closed
Fix the build #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis switched to using Xenial as the default, and the DB is not enabled by default. travis-ci/travis-ci#6842 (comment)
Disable Style/FrozenStringLiteralComment cop for now and remove disabling of unknown cop.
|
Most of the failures have been fixed. There still is a problem with an occasional jruby build failing due to github api rate limiting? See: https://travis-ci.community/t/rvm-tries-to-download-blank-version-of-itself/3972/7 |
MySQL 5.7 no longer supports null default values for the primary key. Override the Native default for primary keys in MySql. https://stackoverflow.com/a/34555109
|
Travis is building jruby correctly again. |
Merged
|
I noticed this PR too late, but I did cherry pick your work on mysql 5.7 and that is now in master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current build fails because of updates in Travis.
Changes were copied from Bump JRuby and the jdk on Travis delayed_job#1092
"Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock'" travis-ci/travis-ci#6842 (comment)