Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Handy things for Heroku #37

Merged
merged 3 commits into from Feb 26, 2014

Conversation

Projects
None yet
2 participants
Owner

danielmorrison commented Feb 25, 2014

  • gzip (cedar stack doesn't do this for us)
  • rails_12factor gem

@laserlemon laserlemon and 1 other commented on an outdated diff Feb 25, 2014

@@ -1,4 +1,5 @@
# This file is used by Rack-based servers to start the application.
require ::File.expand_path('../config/environment', __FILE__)
+use Rack::Deflater
@laserlemon

laserlemon Feb 25, 2014

Owner

Seems like awkward placement. What about this?

@danielmorrison

danielmorrison Feb 25, 2014

Owner

Well, my method is only one line! 😉

I guess I don't really care. I just always do it this way.

danielmorrison added some commits Feb 25, 2014

Add rails_12factor gem
Required for Heroku deployments
Use Rack::Deflater
GZips our responses on Heroku for more speed
Owner

laserlemon commented Feb 26, 2014

🚦 💣 on the streaming endpoint tests. Restarting…

Owner

laserlemon commented Feb 26, 2014

🚦 💣 💥 again. Could it be an issue with streaming GZipped content?

Owner

laserlemon commented Feb 26, 2014

Same failures locally. 😦

Owner

laserlemon commented Feb 26, 2014

👀 🙏 It's a bit hacky.

danielmorrison added a commit that referenced this pull request Feb 26, 2014

@danielmorrison danielmorrison merged commit 09b0ee8 into master Feb 26, 2014

1 check passed

default The Travis CI build passed
Details

@danielmorrison danielmorrison deleted the heroku branch Feb 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment