Skip to content

Loading…

CI changes for Issue 33 #39

Merged
merged 5 commits into from

4 participants

@cbusbey

This change will include test negation in the default test build. This should close out #33 and #38

h/t @levinalex @clabrunda

@laserlemon laserlemon commented on an outdated diff
features/equivalence.feature
@@ -253,7 +253,34 @@ Feature: Equivalence
| true | true |
| updated_at | "2011-07-08 02:28:50" |
And the JSON at "array" should have the following:
- | 0 | "json" |
- | 1 | "spec" |
+ | 0 | "json" |
+ | 1 | "spec" |
@laserlemon Collective Idea member

Let's set this whitespace back to how it was, please. :trollface:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@laserlemon laserlemon commented on an outdated diff
features/equivalence.feature
((8 lines not shown))
And the JSON at "hash" should have the following:
- | json | "spec" |
+ | json | "spec" |
@laserlemon Collective Idea member

This one too, and I'll merge. Thanks! :clap:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@laserlemon
Collective Idea member

Looks great, just a couple picky details and it's good to go. Thanks, @cbusbey!

@cbusbey

All good now?

@laserlemon
Collective Idea member

:metal:

@laserlemon laserlemon merged commit 9c156c1 into collectiveidea:master

1 check passed

Details default The Travis build passed
@cbusbey cbusbey deleted the cbusbey:issue_33 branch
@laserlemon
Collective Idea member

Version 1.1.1 released! Thanks again. :clap:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 12, 2012
  1. @levinalex
Commits on Feb 16, 2013
  1. @clabrunda
Commits on Mar 15, 2013
  1. @cbusbey
  2. @cbusbey

    negative cuke scenarios

    cbusbey committed
Commits on Mar 19, 2013
  1. @cbusbey

    whitespace cleanup

    cbusbey committed
Showing with 36 additions and 3 deletions.
  1. +8 −2 Rakefile
  2. +27 −0 features/equivalence.feature
  3. +1 −1 lib/json_spec/cucumber.rb
View
10 Rakefile
@@ -3,7 +3,13 @@ require "rspec/core/rake_task"
require "cucumber/rake/task"
RSpec::Core::RakeTask.new(:spec)
-Cucumber::Rake::Task.new(:cucumber)
+Cucumber::Rake::Task.new(:cucumber) do |t|
+ t.cucumber_opts = "--tags ~@fail"
+end
-task :test => [:spec, :cucumber]
+Cucumber::Rake::Task.new(:negative_cucumber) do |t|
+ t.cucumber_opts = "--tags @fail --wip"
+end
+
+task :test => [:spec, :cucumber, :negative_cucumber]
task :default => :test
View
27 features/equivalence.feature
@@ -257,3 +257,30 @@ Feature: Equivalence
| 1 | "spec" |
And the JSON at "hash" should have the following:
| json | "spec" |
+
+ @fail
+ Scenario: Table format can fail equivalence
+ When I get the JSON
+ Then the JSON should have the following:
+ | array | ["bad","garbage"] |
+ | array/0 | "json" |
+ | array/1 | "spec" |
+ | created_at | "2011-07-08 02:27:34" |
+ | empty_array | [] |
+ | empty_hash | {} |
+ | false | false |
+ | float | 10.0 |
+ | hash | {"json":"spec"} |
+ | hash/json | "spec" |
+ | id | 1 |
+ | integer | 10 |
+ | negative | -10 |
+ | null | null |
+ | string | "json_spec" |
+ | true | true |
+ | updated_at | "2011-07-08 02:28:50" |
+ And the JSON at "array" should have the following:
+ | should | "fail" |
+ | 1 | "spec" |
+ And the JSON at "hash" should have the following:
+ | random | "junk" |
View
2 lib/json_spec/cucumber.rb
@@ -59,7 +59,7 @@
end
Then /^the (?:JSON|json)(?: response)?(?: at "(.*)")? should have the following:$/ do |base, table|
- table.rows.each do |path, value|
+ table.raw.each do |path, value|
path = [base, path].compact.join("/")
if value
Something went wrong with that request. Please try again.