Skip to content

Refactor #63

Closed
wants to merge 4 commits into from

2 participants

@charlierudolph

No description provided.

@charlierudolph

@laserlemon thoughts?

@laserlemon laserlemon commented on the diff Jun 17, 2014
lib/json_spec/cucumber.rb
@@ -2,6 +2,14 @@
World(JsonSpec::Helpers, JsonSpec::Matchers)
+def _match(negative, matcher)
@laserlemon
Collective Idea member
laserlemon added a note Jun 17, 2014

Since this method is being defined in the main object space, we should probably name it something less collision-prone like _json_spec_match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@laserlemon
Collective Idea member

Outside of the method rename, 👍. Would this require a version bump or do you think this is a completely backwards compatible refactor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.