Update for RSpec 3 beta 2 #71

Merged
merged 4 commits into from Jun 17, 2014

Conversation

Projects
None yet
6 participants
@skalee
Contributor

skalee commented Feb 25, 2014

  1. Support new matcher interface.

    Do you prefer alias or alias_method? I'm using alias because it's RDoc-friendly and those matchers are not likely to be subclassed, but I can change to alias_method if you want.

  2. Explicitly enable both expectation syntaxes.

    Both fashions something.should be_like_this and expect(something).to be_like_this are used in tests so I enabled them. As in above, I can change it if you want to gradually force one or another and warnings seem helpful.

skalee added some commits Feb 25, 2014

Update matcher protocol for RSpec 3
"Update matcher protocol and custom matcher DSL to better align with the
newer expect syntax. If you want your matchers to maintain compatibility
with multiple versions of RSpec, you can alias the new names to the old.
(Myron Marston)
* failure_message_for_should => failure_message
* failure_message_for_should_not => failure_message_when_negated
* match_for_should => match
* match_for_should_not => match_when_negated"

http://myronmars.to/n/dev-blog/2014/02/rspec-2-99-and-3-0-beta-2-have-been-released
@skalee

This comment has been minimized.

Show comment Hide comment
@skalee

skalee Feb 25, 2014

Contributor

BTW how about setting RSpec to fail in case of deprecation warnings? If you don't need them to promote one syntax or another, they would be very helpful. Some pull requests (like #64) were created before beta 2 and they don't honor most recent deprecations.

Contributor

skalee commented Feb 25, 2014

BTW how about setting RSpec to fail in case of deprecation warnings? If you don't need them to promote one syntax or another, they would be very helpful. Some pull requests (like #64) were created before beta 2 and they don't honor most recent deprecations.

@johanneswuerbach

This comment has been minimized.

Show comment Hide comment
@johanneswuerbach

johanneswuerbach Apr 24, 2014

👍

@skalee

This comment has been minimized.

Show comment Hide comment
@skalee

skalee Jun 9, 2014

Contributor

Dependencies updated. Could anyone with an active real-life project confirm that it works well with stable RSpec 3? Tests indicate no problems.

Contributor

skalee commented Jun 9, 2014

Dependencies updated. Could anyone with an active real-life project confirm that it works well with stable RSpec 3? Tests indicate no problems.

@dredozubov

This comment has been minimized.

Show comment Hide comment
@dredozubov

dredozubov Jun 10, 2014

@laserlemon @skalee looks ok, can we merge it?

@laserlemon @skalee looks ok, can we merge it?

@mscottford

This comment has been minimized.

Show comment Hide comment
@mscottford

mscottford Jun 11, 2014

I can confirm that this is working.

I can confirm that this is working.

@ToMoCoop

This comment has been minimized.

Show comment Hide comment
@ToMoCoop

ToMoCoop Jun 17, 2014

Can someone merge this PR please?

Can someone merge this PR please?

laserlemon added a commit that referenced this pull request Jun 17, 2014

@laserlemon laserlemon merged commit 4aa659c into collectiveidea:master Jun 17, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@laserlemon

This comment has been minimized.

Show comment Hide comment
@laserlemon

laserlemon Jun 17, 2014

Contributor

Version 1.1.2 released.

Contributor

laserlemon commented Jun 17, 2014

Version 1.1.2 released.

@dredozubov

This comment has been minimized.

Show comment Hide comment
@dredozubov

dredozubov Jun 17, 2014

👍

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment