Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assorted RSpec warnings when running rspec spec --warnings #95

Merged
merged 3 commits into from May 3, 2017
Merged

Fix assorted RSpec warnings when running rspec spec --warnings #95

merged 3 commits into from May 3, 2017

Conversation

shekibobo
Copy link
Contributor

@shekibobo shekibobo commented May 3, 2017 •
edited

  • Initialize instance variables such as @path
  • Use attr_accessor for simple accessors
  • Use eq instead of == in expectations

Closes #77. Fixes #78.

@shekibobo
Update changelog
eab36d3 
[ci skip]
@shekibobo shekibobo merged commit 84fcbf4 into master May 3, 2017
@shekibobo shekibobo deleted the update-rspec-usage branch May 3, 2017 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@shekibobo